fix: additional_ip_ranges_config - again #2458

DrFaust92 · 2025-09-26T02:46:37Z

apologies, missed this again

apeabody · 2025-09-26T03:16:12Z

/gcbrun

pib · 2025-09-26T16:56:38Z

autogen/main/cluster.tf.tmpl

+        subnetwork           = var.additional_ip_ranges_config.value.subnetwork
+        pod_ipv4_range_names = var.additional_ip_ranges_config.value.pod_ipv4_range_names


Shouldn't this be like this instead?

Suggested change

subnetwork = var.additional_ip_ranges_config.value.subnetwork

pod_ipv4_range_names = var.additional_ip_ranges_config.value.pod_ipv4_range_names

subnetwork = additional_ip_ranges_config.value.subnetwork

pod_ipv4_range_names = additional_ip_ranges_config.value.pod_ipv4_range_names

Based on the docs at https://developer.hashicorp.com/terraform/language/expressions/dynamic-blocks

+1

@DrFaust92 - Can you please add a usage to the existing node_pool example and test data so we have sufficient test coverage. Thanks!

Ok, I think i added the changes and test. can we trigger a run?

apeabody · 2025-10-03T04:45:15Z

/gcbrun

apeabody · 2025-10-03T20:08:23Z

/gcbrun

apeabody · 2025-10-03T20:08:49Z

/gcbrun

apeabody · 2025-10-03T22:10:05Z

Hi @DrFaust92 - I'm going to run the test again, but this is the only PR I'm currently seeing this error:

Error: Cannot determine region: set in this resource, or set provider-level 'region' or 'zone'.

  with module.example.module.gke.google_container_cluster.primary,
  on ../../../modules/beta-public-cluster/cluster.tf line 22, in resource "google_container_cluster" "primary":
  22: resource "google_container_cluster" "primary" {
}

apeabody · 2025-10-03T22:10:17Z

/gcbrun

Signed-off-by: drfaust92 <[email protected]>

apeabody · 2025-10-07T21:29:04Z

Thanks @DrFaust92, still seeing:

TestNodePool 2025-10-07T21:08:49Z command.go:212: module.example.module.gke.google_container_cluster.primary: Creating...
TestNodePool 2025-10-07T21:08:49Z command.go:212: 
TestNodePool 2025-10-07T21:08:49Z command.go:212: Error: Cannot determine region: set in this resource, or set provider-level 'region' or 'zone'.
TestNodePool 2025-10-07T21:08:49Z command.go:212: 
TestNodePool 2025-10-07T21:08:49Z command.go:212:   with module.example.module.gke.google_container_cluster.primary,
TestNodePool 2025-10-07T21:08:49Z command.go:212:   on ../../../modules/beta-public-cluster/cluster.tf line 22, in resource "google_container_cluster" "primary":
TestNodePool 2025-10-07T21:08:49Z command.go:212:   22: resource "google_container_cluster" "primary" {
TestNodePool 2025-10-07T21:08:49Z command.go:212:

cwh-hcl · 2025-10-08T16:41:41Z

I don't think the additional_ip_ranges_config variable needs to be defined as a list... see my comment here -> #2437 (comment)

Signed-off-by: drfaust92 <[email protected]>

DrFaust92 · 2025-10-08T18:09:37Z

examples/node_pool/main.tf

  additional_ip_ranges_config = [
    {
-      subnetwork           = var.subnetwork
+      subnetwork           = "projects/${var.project_id}/regions/${var.region}/subnetworks/${var.subnetwork}"


@apeabody I think this was the issue, plan passes either way. but error is strange

additional_ip_ranges_config is not a list/array as defined in the google_container_cluster documentation. See https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#additional_ip_ranges_config-1

yes it is, according to provider code and google container api
https://github.com/hashicorp/terraform-provider-google/blob/4003211203eb953bab681ae9a2972eff1a90ef09/google/services/container/resource_container_cluster.go#L1695

Well that's interesting. So as a data point, I was able to update the module locally so that it was an 'object' and NOT a 'list' and it then the terraform plan handled this section for me correctly. As a list it complained, as detailed in the comment I referenced above.

I'm not sure why the discrepancy..?

It looks like in the Google console UI it is a List so I can try again and see what comes out of the changes here

@DrFaust92 sorry for the spam, just want to let you know you are right and the changes you have here I tested locally in my environment and fix my issue, so for what it's worth LGTM! Thanks.

Thanks @DrFaust92 - Looks like we are close

Error: Error updating cluster for []: googleapi: Error 400: The cluster's default subnetwork cannot be used as an additional subnetwork.

If needed, this is where the current one is defined: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/test/fixtures/node_pool/network.tf

lets try once more @apeabody , thanks for bearing with me on this

Thanks @DrFaust92!

Hi @DrFaust92 - Looks like the docs need to be regenerated after the change. Thanks!

Checking submodule's files generation diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/examples/node_pool/README.md /tmp/tmp.VdIZFvHmj1/workspace/examples/node_pool/README.md 10a11 > | additional\_ip\_pod\_range\_subnetwork | The subnetwork to host the additional pod range in | `any` | n/a | yes | Error: submodule's files generation has not been run, please run the 'make build' command and commit changes Checking for documentation generation diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/examples/node_pool/README.md /tmp/tmp.QlBKcRfkkq/generate_docs/workspace/examples/node_pool/README.md 10a11 > | additional\_ip\_pod\_range\_subnetwork | The subnetwork to host the additional pod range in | `any` | n/a | yes | Error: Documentation generation has not been run, please run the 'make docker_generate_docs' command and commit the above changes.

apeabody · 2025-10-08T18:19:17Z

/gcbrun

Signed-off-by: drfaust92 <[email protected]>

apeabody · 2025-10-08T23:58:16Z

/gcbrun

DrFaust92 marked this pull request as ready for review September 26, 2025 02:46

DrFaust92 requested review from apeabody, ericyz and a team as code owners September 26, 2025 02:46

pib reviewed Sep 26, 2025

View reviewed changes

DrFaust92 force-pushed the fix-pods-ip-again branch from 1c84b6c to 8960c33 Compare September 28, 2025 01:59

DrFaust92 marked this pull request as draft September 28, 2025 01:59

DrFaust92 force-pushed the fix-pods-ip-again branch from 8960c33 to a82e717 Compare October 2, 2025 23:58

DrFaust92 marked this pull request as ready for review October 3, 2025 01:07

apeabody self-assigned this Oct 3, 2025

DrFaust92 added 4 commits October 4, 2025 10:37

fix ranges variable

7d50b79

Signed-off-by: drfaust92 <[email protected]>

CR comments

2853d0a

Signed-off-by: drfaust92 <[email protected]>

add tests

177378f

Signed-off-by: drfaust92 <[email protected]>

add tests

faed61b

Signed-off-by: drfaust92 <[email protected]>

apeabody mentioned this pull request Oct 8, 2025

Unable to specify pod_ipv4_range_names? #2437

Open

DrFaust92 force-pushed the fix-pods-ip-again branch from db2480a to faed61b Compare October 8, 2025 17:54

DrFaust92 marked this pull request as draft October 8, 2025 17:54

add tests

b5d6784

Signed-off-by: drfaust92 <[email protected]>

DrFaust92 commented Oct 8, 2025

View reviewed changes

DrFaust92 marked this pull request as ready for review October 8, 2025 18:10

align tests

6b7692a

Signed-off-by: drfaust92 <[email protected]>

		subnetwork = var.additional_ip_ranges_config.value.subnetwork
		pod_ipv4_range_names = var.additional_ip_ranges_config.value.pod_ipv4_range_names

fix: additional_ip_ranges_config - again #2458

Are you sure you want to change the base?

fix: additional_ip_ranges_config - again #2458

Uh oh!

Conversation

DrFaust92 commented Sep 26, 2025 • edited by apeabody Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

apeabody commented Sep 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apeabody commented Oct 3, 2025

Uh oh!

apeabody commented Oct 3, 2025

Uh oh!

apeabody commented Oct 3, 2025

Uh oh!

apeabody commented Oct 3, 2025

Uh oh!

apeabody commented Oct 3, 2025

Uh oh!

apeabody commented Oct 7, 2025

Uh oh!

cwh-hcl commented Oct 8, 2025

Uh oh!

DrFaust92 Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

apeabody commented Oct 8, 2025

Uh oh!

apeabody commented Oct 8, 2025

Uh oh!

Uh oh!

DrFaust92 commented Sep 26, 2025 •

edited by apeabody

Loading

DrFaust92 Oct 8, 2025 •

edited

Loading