add: gnome-shell-extension-tailscale-status #2961
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madonuko
requested changes
Jan 15, 2025
Comment on lines
+72
to
+78
| mv %{_localstatedir}/lib/rpm-state/%{uuid}/metadata.json /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/metadata.json | ||
| mv %{_localstatedir}/lib/rpm-state/%{uuid}/extension.js /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/extension.js | ||
| mv %{_localstatedir}/lib/rpm-state/%{uuid}/prefs.js /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/prefs.js | ||
| mv %{_localstatedir}/lib/rpm-state/%{uuid}/icon-down.svg /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/icon-down.svg | ||
| mv %{_localstatedir}/lib/rpm-state/%{uuid}/icon-exit-node.svg /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/icon-exit-node.svg | ||
| mv %{_localstatedir}/lib/rpm-state/%{uuid}/icon-up.svg /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/icon-up.svg | ||
| mv %{_localstatedir}/lib/rpm-state/%{uuid}/schemas/* /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/schemas/ |
There was a problem hiding this comment.
not doable, you should not do this itfp
| This extension is in no way affiliated with Tailscale Inc. | ||
|
|
||
| %prep | ||
| wget https://extensions.gnome.org/review/download/58475.shell-extension.zip |
There was a problem hiding this comment.
can you grab this from %SOURCE0?
There was a problem hiding this comment.
I tried but it didn't like it, I'll try again.
Comment on lines
+63
to
+69
| #Since this is a User Extension, we muct only install for the current user | ||
| current_user=$(logname) | ||
| echo "Running post-transaction scripts as user ${current_user}..." | ||
|
|
||
| # Create the User Extensions directories in the user's home directory | ||
| mkdir -p /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid} | ||
| mkdir -p /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/schemas |
There was a problem hiding this comment.
even if this is a user extension you can't just interfere with the user home directory.
dnf is a system package manager by nature and you can't just do this
There was a problem hiding this comment.
Hmm, so it pretty much needs to be a system extension or can't be packaged?
There was a problem hiding this comment.
well you need to figure out a way to install user extensions in a system-wide way (a bit like user services for systemd)
korewaChino
suggested changes
Jan 15, 2025
Comment on lines
+39
to
+69
| %install | ||
| mkdir -p %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid} | ||
| mkdir -p %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/schemas | ||
|
|
||
| install -Dm644 metadata.json %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/metadata.json | ||
| install -Dm644 extension.js %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/extension.js | ||
| install -Dm644 prefs.js %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/prefs.js | ||
| install -Dm644 icon-down.svg %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/icon-down.svg | ||
| install -Dm644 icon-exit-node.svg %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/icon-exit-node.svg | ||
| install -Dm644 icon-up.svg %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/icon-up.svg | ||
| install -Dm644 schemas/* %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/schemas/ | ||
|
|
||
| %files | ||
| %dir %{_localstatedir}/lib/rpm-state/%{uuid} | ||
| %dir %{_localstatedir}/lib/rpm-state/%{uuid}/schemas | ||
| %{_localstatedir}/lib/rpm-state/%{uuid}/metadata.json | ||
| %{_localstatedir}/lib/rpm-state/%{uuid}/extension.js | ||
| %{_localstatedir}/lib/rpm-state/%{uuid}/prefs.js | ||
| %{_localstatedir}/lib/rpm-state/%{uuid}/icon-down.svg | ||
| %{_localstatedir}/lib/rpm-state/%{uuid}/icon-exit-node.svg | ||
| %{_localstatedir}/lib/rpm-state/%{uuid}/icon-up.svg | ||
| %{_localstatedir}/lib/rpm-state/%{uuid}/schemas/* | ||
|
|
||
| %post | ||
| #Since this is a User Extension, we muct only install for the current user | ||
| current_user=$(logname) | ||
| echo "Running post-transaction scripts as user ${current_user}..." | ||
|
|
||
| # Create the User Extensions directories in the user's home directory | ||
| mkdir -p /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid} | ||
| mkdir -p /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/schemas |
There was a problem hiding this comment.
just do this bro
Suggested change
| %install | |
| mkdir -p %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid} | |
| mkdir -p %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/schemas | |
| install -Dm644 metadata.json %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/metadata.json | |
| install -Dm644 extension.js %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/extension.js | |
| install -Dm644 prefs.js %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/prefs.js | |
| install -Dm644 icon-down.svg %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/icon-down.svg | |
| install -Dm644 icon-exit-node.svg %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/icon-exit-node.svg | |
| install -Dm644 icon-up.svg %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/icon-up.svg | |
| install -Dm644 schemas/* %{buildroot}%{_localstatedir}/lib/rpm-state/%{uuid}/schemas/ | |
| %files | |
| %dir %{_localstatedir}/lib/rpm-state/%{uuid} | |
| %dir %{_localstatedir}/lib/rpm-state/%{uuid}/schemas | |
| %{_localstatedir}/lib/rpm-state/%{uuid}/metadata.json | |
| %{_localstatedir}/lib/rpm-state/%{uuid}/extension.js | |
| %{_localstatedir}/lib/rpm-state/%{uuid}/prefs.js | |
| %{_localstatedir}/lib/rpm-state/%{uuid}/icon-down.svg | |
| %{_localstatedir}/lib/rpm-state/%{uuid}/icon-exit-node.svg | |
| %{_localstatedir}/lib/rpm-state/%{uuid}/icon-up.svg | |
| %{_localstatedir}/lib/rpm-state/%{uuid}/schemas/* | |
| %post | |
| #Since this is a User Extension, we muct only install for the current user | |
| current_user=$(logname) | |
| echo "Running post-transaction scripts as user ${current_user}..." | |
| # Create the User Extensions directories in the user's home directory | |
| mkdir -p /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid} | |
| mkdir -p /home/${current_user}/.local/share/gnome-shell/extensions/%{uuid}/schemas | |
| %install | |
| mkdir -p %%{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas | |
| install -Dm644 metadata.json %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/metadata.json | |
| install -Dm644 extension.js %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/extension.js | |
| install -Dm644 prefs.js %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/prefs.js | |
| install -Dm644 icon-down.svg %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/icon-down.svg | |
| install -Dm644 icon-exit-node.svg %{buildroot}%{_datadir}/gnome-shell/extensions/icon-exit-node.svg | |
| install -Dm644 icon-up.svg %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/icon-up.svg | |
| install -Dm644 schemas/* %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas/ | |
| %files | |
| %dir %{_datadir}/gnome-shell/extensions/%{uuid} | |
| %dir %{_datadir}/gnome-shell/extensions/%{uuid}/schemas/ | |
madonuko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for Taidan