Skip to content

[Testflight] Connection - #1

Open
mesmerze wants to merge 6 commits into
masterfrom
testflight/connection
Open

[Testflight] Connection#1
mesmerze wants to merge 6 commits into
masterfrom
testflight/connection

Conversation

@mesmerze

@mesmerze mesmerze commented Mar 23, 2020 •
edited
Loading

Copy link
Copy Markdown

Why:
This fork of the glorious Fastlane is made to be able to reuse their implementation of TestFlight and ConenctAPI APIs. Moreover, this fork solves some dependency collisions with CIRRO.

Another goal of this fork is to extract required logic, but make it supportable and updatable from origin's master.

Specs were made green by the way.

rspec
Finished in 1 minute 12.41 seconds (files took 2.15 seconds to load)
688 examples, 0 failures

@mesmerze mesmerze self-assigned this Mar 23, 2020
@mesmerze mesmerze added the DO NOT MERGE This doesn't seem right label Mar 23, 2020
mesmerze
mesmerze commented Mar 23, 2020
View reviewed changes
Comment thread fastlane.gemspec
Comment on lines -59 to +66
spec.add_dependency('slack-notifier', '>= 2.0.0', '< 3.0.0') # Slack notifications
spec.add_dependency('xcodeproj', '>= 1.13.0', '< 2.0.0') # Modify Xcode projects
spec.add_dependency('xcpretty', '~> 0.3.0') # prettify xcodebuild output
spec.add_dependency('terminal-notifier', '>= 2.0.0', '< 3.0.0') # macOS notifications
spec.add_dependency('terminal-table', '>= 1.4.5', '< 2.0.0') # Actions documentation
spec.add_dependency('plist', '>= 3.1.0', '< 4.0.0') # Needed for set_build_number_repository and get_info_plist_value actions
spec.add_dependency('CFPropertyList', '>= 2.3', '< 4.0.0') # Needed to be able to read binary plist format
spec.add_dependency('addressable', '>= 2.3', '< 3.0.0') # Support for URI templates
spec.add_dependency('multipart-post', '~> 2.0.0') # Needed for uploading builds to appetize
spec.add_dependency('word_wrap', '~> 1.0.0') # to add line breaks for tables with long strings

spec.add_dependency('public_suffix', '~> 2.0.0') # https://github.com/fastlane/fastlane/issues/10162

# TTY dependencies
spec.add_dependency('tty-screen', '>= 0.6.3', '< 1.0.0') # detect the terminal width
spec.add_dependency('tty-spinner', '>= 0.8.0', '< 1.0.0') # loading indicators

spec.add_dependency('babosa', '>= 1.0.2', "< 2.0.0")
spec.add_dependency('colored') # colored terminal output
spec.add_dependency('commander-fastlane', '>= 4.4.6', '< 5.0.0') # CLI parser
spec.add_dependency('excon', '>= 0.71.0', '< 1.0.0') # Great HTTP Client
spec.add_dependency('faraday-cookie_jar', '~> 0.0.6')
spec.add_dependency('faraday', '~> 0.17') # Used for deploygate, hockey and testfairy actions
spec.add_dependency('faraday_middleware', '~> 0.13.1') # same as faraday
spec.add_dependency('fastimage', '>= 2.1.0', '< 3.0.0') # fetch the image sizes from the screenshots
spec.add_dependency('gh_inspector', '>= 1.1.2', '< 2.0.0') # search for issues on GitHub when something goes wrong
spec.add_dependency('highline', '>= 1.7.2', '< 2.0.0') # user inputs (e.g. passwords)
spec.add_dependency('json', '< 3.0.0') # Because sometimes it's just not installed
spec.add_dependency('mini_magick', '>= 4.9.4', '< 5.0.0') # To open, edit and export PSD files
spec.add_dependency('multi_xml', '~> 0.5')
spec.add_dependency('rubyzip', '>= 1.3.0', '< 2.0.0') # fix swift/ipa in gym
spec.add_dependency('security', '= 0.1.3') # macOS Keychain manager, a dead project, no updates expected
spec.add_dependency('xcpretty-travis-formatter', '>= 0.0.3')
spec.add_dependency('dotenv', '>= 2.1.1', '< 3.0.0')
spec.add_dependency('bundler', '>= 1.12.0', '< 3.0.0') # Used for fastlane plugins
spec.add_dependency('simctl', '~> 1.6.3') # Used for querying and interacting with iOS simulators
spec.add_dependency('jwt', '~> 2.1.0') # Used for generating authentication tokens for AppStore connect api

# need to lock 0.11 and under when using less than Ruby 2.4 to prevent install issues when using 'gem install'
# 'gem install' does not respect Ruby versions and would try installing 0.12 on Ruby 2.3 or less
# https://github.com/fastlane/fastlane/pull/15483
if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.4')
spec.add_dependency('signet', '<= 0.11')
spec.add_dependency('google-cloud-env', '1.2.1')
spec.add_dependency('google-cloud-core', '1.3.2')
STDERR.puts("WARNING: Locking to a potentially insecure version of 'signet', 'google-cloud-env', and 'google-cloud-core' because you are using a version of Ruby which is marked as End-Of-Life. Please upgrade your Ruby installation to 2.4 or later")
end

# The Google API Client gem is *not* API stable between minor versions - hence the specific version locking here.
# If you upgrade this gem, make sure to upgrade the users of it as well.
spec.add_dependency('google-api-client', '>= 0.29.2', '< 0.37.0') # Google API Client to access Play Publishing API
spec.add_dependency('google-cloud-storage', '>= 1.15.0', '< 2.0.0') # Access Google Cloud Storage for match

spec.add_dependency('emoji_regex', '>= 0.1', '< 2.0') # Used to scan for Emoji in the changelog
spec.add_dependency('plist', '>= 3.1.0', '< 4.0.0') # Needed for set_build_number_repository and get_info_plist_value actions
spec.add_dependency('babosa', '>= 1.0.2', "< 2.0.0")
spec.add_dependency('fastimage', '>= 2.1.0', '< 3.0.0')
spec.add_dependency('colored')

@mesmerze mesmerze Mar 23, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencies were reconcidered

@mesmerze
mesmerze force-pushed the testflight/connection branch from 92d8064 to b6daf23 Compare March 25, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mesmerze mesmerze

Labels

DO NOT MERGE This doesn't seem right

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mesmerze