Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAWSM #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add JAWSM #22

wants to merge 4 commits into from

Conversation

drogus
Copy link

@drogus drogus commented Dec 16, 2024

I still get a lot more failures with this than I would have expected, but I'm pretty sure it's the problem with JAWSM not implementing enough to run the standard harness for most tests, cause some of the tests indeed pass

@drogus
Copy link
Author

drogus commented Dec 17, 2024

I think that something might be wrong with this PR, after all. I had some time to look into it yesterday and I've checked some of the failures. One thing I've noticed is that syntax error tests all fail, for example:

FAIL 1 test/annexB/language/statements/for-in/bare-initializer.js
SyntaxError: invalid variable for iterable loop at line 212, col 12

FAIL 2 test/annexB/language/statements/for-in/bare-initializer.js
SyntaxError: invalid variable for iterable loop at line 213, col 12

I don't think it's a problem with my runner, but rather with parsing the errors. I say that, cause when I changed porffor's harness to run my runner, the test passes. And it seems that it passes with SyntaxError: whatever string in the output. The problem is I don't know which part of the code to change to make it pass properly. I will probably have some time to debug later this week or over the weekend, but if someone more familiar with test262 harness knows what's the problem, I'd appreciate any pointers.

@drogus
Copy link
Author

drogus commented Dec 17, 2024

Ok, this was quite silly actually 😅

I haven't noticed that porffor has code that disables Node's output colouring, which could definitely result in a problem when parsing the output (and I use Node.js as the WASM runtime at the moment). The syntax tests pass without issues now :D

@drogus
Copy link
Author

drogus commented Dec 18, 2024

Corresponding PR in test262.fyi: test262-fyi/test262.fyi#87

lib/agents/jawsm.js Outdated Show resolved Hide resolved
lib/agents/jawsm.js Outdated Show resolved Hide resolved
lib/agents/jawsm.js Outdated Show resolved Hide resolved
lib/agents/jawsm.js Outdated Show resolved Hide resolved
@drogus
Copy link
Author

drogus commented Dec 18, 2024

It's much more bare bones now 😅

Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers :)

Looks vaguely correct to me but I'll defer to @CanadaHonk for another review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants