-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAWSM #22
base: master
Are you sure you want to change the base?
Add JAWSM #22
Conversation
I think that something might be wrong with this PR, after all. I had some time to look into it yesterday and I've checked some of the failures. One thing I've noticed is that syntax error tests all fail, for example:
I don't think it's a problem with my runner, but rather with parsing the errors. I say that, cause when I changed porffor's harness to run my runner, the test passes. And it seems that it passes with |
Ok, this was quite silly actually 😅 I haven't noticed that porffor has code that disables Node's output colouring, which could definitely result in a problem when parsing the output (and I use Node.js as the WASM runtime at the moment). The syntax tests pass without issues now :D |
Corresponding PR in test262.fyi: test262-fyi/test262.fyi#87 |
It's much more bare bones now 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers :)
Looks vaguely correct to me but I'll defer to @CanadaHonk for another review.
I still get a lot more failures with this than I would have expected, but I'm pretty sure it's the problem with JAWSM not implementing enough to run the standard harness for most tests, cause some of the tests indeed pass