Skip to content

fix: daemon crash for sending to closed channel #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: daemon crash for sending to closed channel #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33f118d
fix: daemon crash for sending to closed channel
yihuang May 24, 2024
8056c36
cleanup
yihuang May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions sync/client_conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ func (c *DefaultClient) nextID() (id string) {
}

func (c *DefaultClient) responsesWorker() {
// sending to channel could panic due to concurrent close
defer func() {
c.wg.Done()

if err := recover(); err != nil {
c.log.Errorw("panic in responsesWorker", "error", err)
}
}()

for {
res, err := c.readSocket()
if err != nil {
Expand All @@ -43,8 +52,6 @@ func (c *DefaultClient) responsesWorker() {
ch <- res
}
}

c.wg.Done()
}

func (c *DefaultClient) makeRequest(ctx context.Context, req *sync.Request) (chan *sync.Response, error) {
Expand Down