Skip to content

chore: unpin aria-query #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

benmccann
Copy link

@benmccann benmccann commented Jul 26, 2025

What:

Unpin aria-query

Why:

I have multiple versions of aria-query in my project. This allows it to dedupe

How:

See #1341 (comment) for a discussion of why the CI is failing. It would be nice to merge that PR and then add a lockfile to this project

Checklist:

  • Documentation added to the
    docs site - N/A
  • Tests - N/A
  • TypeScript definitions updated - N/A
  • Ready to be merged

@MatanBobi
Copy link
Member

Thanks for this @benmccann but we're currently not willing to remove the pin. aria-query aren't following semantic versioning tightly and every minor change which seems like an addition on their end might break existing tests for users of testing-library.
If you have any issues with conflicting versions of aria-query, I recommend using overrides to enforce one version is installed.

@MatanBobi MatanBobi closed this Jul 26, 2025
@benmccann
Copy link
Author

Can we reopen this and do the upgrade without the pin?

@MatanBobi
Copy link
Member

Every upgrade we do to aria-query requires several checks based on aria-query's release notes to verify if there were any changes that might cause a breaking change to our users.
If you're willing to take that on, I'll be happy to re-open the PR. Unfortunately I don't have the capacity currently to review the changes in aria-query.

@benmccann
Copy link
Author

5.3.2 is certainly not breaking and 5.3.1 has only a few changes: https://github.com/A11yance/aria-query/blob/main/CHANGELOG.md#531

I'm unsure of what types of changes have caused users of this project problems in the past. We use this library in Svelte and would be fine to upgrade based on the changelog, but I'm not exactly sure how the library is used here and if these changes would be considered safe or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants