Skip to content

fix(durable-storage): pass resolver where needed to make build pass#806

Closed
vapourismo wants to merge 1 commit intomainfrom
ole/push-lqokqzkrksow
Closed

fix(durable-storage): pass resolver where needed to make build pass#806
vapourismo wants to merge 1 commit intomainfrom
ole/push-lqokqzkrksow

Conversation

@vapourismo
Copy link
Collaborator

Fixes the durable storage build.

Copy link
Contributor

@kurtisc kurtisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #805

@github-actions
Copy link

Benchmark results for revision abab5e5:

Metric Duration TPS
Mean 1.513138798s 26.435
Worst 1.521190242s 26.295
Best 1.505421378s 26.571
Standard Deviation ±4.865118ms ±0.085
Full results
Run Transfers Duration TPS
1 40 1.520821041s 26.302
2 40 1.514634436s 26.409
3 40 1.518327116s 26.345
4 40 1.509805177s 26.493
5 40 1.508312731s 26.520
6 40 1.514903514s 26.404
7 40 1.515647697s 26.391
8 40 1.506309472s 26.555
9 40 1.506372469s 26.554
10 40 1.51467381s 26.408
11 40 1.513674936s 26.426
12 40 1.510503003s 26.481
13 40 1.505421378s 26.571
14 40 1.510150556s 26.487
15 40 1.521190242s 26.295
16 40 1.518129631s 26.348
17 40 1.518804161s 26.337
18 40 1.516472941s 26.377
19 40 1.511390054s 26.466
20 40 1.507231601s 26.539

Compare the results above with those for the default branch.

@kurtisc
Copy link
Contributor

kurtisc commented Feb 10, 2026

image

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.05%. Comparing base (68bfca7) to head (af00ca9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   91.06%   91.05%   -0.01%     
==========================================
  Files         110      110              
  Lines       20831    20831              
  Branches    20831    20831              
==========================================
- Hits        18970    18968       -2     
- Misses       1488     1490       +2     
  Partials      373      373              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vapourismo vapourismo closed this Feb 10, 2026
auto-merge was automatically disabled February 10, 2026 12:59

Pull request was closed

@vapourismo vapourismo deleted the ole/push-lqokqzkrksow branch February 10, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants