feat(outbox): verify outbox proofs#809
Draft
victor-dumitrescu wants to merge 1 commit intovdum/rv-877from
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vdum/rv-877 #809 +/- ##
===============================================
- Coverage 91.16% 91.16% -0.01%
===============================================
Files 110 110
Lines 21206 21235 +29
Branches 21206 21235 +29
===============================================
+ Hits 19333 19359 +26
- Misses 1498 1501 +3
Partials 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
46a2cdc to
f2589a9
Compare
76fdfcc to
0886566
Compare
f2589a9 to
1c23b16
Compare
0886566 to
ca6fd05
Compare
1c23b16 to
0f07ca4
Compare
ca6fd05 to
ec9b624
Compare
f7beb2a to
8ddff86
Compare
fd14151 to
eb9ca35
Compare
ed4b4a0 to
8dfe34b
Compare
eb9ca35 to
52cf975
Compare
8dfe34b to
c9e7518
Compare
52cf975 to
592faa4
Compare
c9e7518 to
56a7a85
Compare
01886c1 to
fec1f02
Compare
8a86edb to
d8dceda
Compare
fec1f02 to
ec13689
Compare
d8dceda to
d9d63ee
Compare
ec13689 to
8a3a56e
Compare
d9d63ee to
3a51206
Compare
8a3a56e to
301d866
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RV-879.
What
The outbox can now verify an outbox proof.
Why
The outbox needs to support verifying inclusion proofs for messages.
How
Outbox proof verification employs the same mechanism used for fraud proofs. The difference is that the verified state transition is not one step of the PVM but a successful read of the given message from the outbox.
Manually Testing
In particular, the
test_outbox_proofs_dummy_kerneltest.Regressions
Tasks for the Author