Skip to content

refactor(durable-storage): categorise error types into operational and invalid arguments#814

Merged
vapourismo merged 1 commit intomainfrom
ole/push-vtywzosmovko
Feb 13, 2026
Merged

refactor(durable-storage): categorise error types into operational and invalid arguments#814
vapourismo merged 1 commit intomainfrom
ole/push-vtywzosmovko

Conversation

@vapourismo
Copy link
Collaborator

@vapourismo vapourismo commented Feb 12, 2026

What

Refactor and reduce the number of error types in the Durable Storage crate. All operational errors (not caused directly by the user) will surface as OperationalError. Misuse errors will appear as InvalidArgumentError.

Needed for #770.

Why

Improve the error situation in the Durable Storage crate per this thread.

Manually Testing

make all

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

@vapourismo vapourismo changed the base branch from main to ole/push-owwkptqkmrvv February 12, 2026 14:15
@vapourismo vapourismo force-pushed the ole/push-vtywzosmovko branch from 6f41606 to c6434ae Compare February 12, 2026 14:17
@vapourismo vapourismo force-pushed the ole/push-owwkptqkmrvv branch from 8b4f061 to 0a7fd7a Compare February 12, 2026 14:17
@vapourismo vapourismo force-pushed the ole/push-vtywzosmovko branch from c6434ae to 05a0f78 Compare February 12, 2026 14:18
@vapourismo vapourismo changed the title refactor(durable-storage): categorise error types into opertional and invalid arguments refactor(durable-storage): categorise error types into operational and invalid arguments Feb 12, 2026
@vapourismo vapourismo force-pushed the ole/push-vtywzosmovko branch from 05a0f78 to 0b71447 Compare February 12, 2026 14:20
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.08%. Comparing base (c98f128) to head (e14864c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   91.10%   91.08%   -0.02%     
==========================================
  Files         110      110              
  Lines       20913    20913              
  Branches    20913    20913              
==========================================
- Hits        19052    19049       -3     
- Misses       1488     1491       +3     
  Partials      373      373              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vapourismo vapourismo force-pushed the ole/push-vtywzosmovko branch 6 times, most recently from d53fc19 to 2edd59c Compare February 12, 2026 15:20
@vapourismo vapourismo marked this pull request as ready for review February 12, 2026 15:27
@github-actions
Copy link

Benchmark results for revision 2dcf27f:

Metric Duration TPS
Mean 1.531986762s 26.110
Worst 1.54139479s 25.951
Best 1.522877409s 26.266
Standard Deviation ±5.762039ms ±0.098
Full results
Run Transfers Duration TPS
1 40 1.53797487s 26.008
2 40 1.527123205s 26.193
3 40 1.531752013s 26.114
4 40 1.538498351s 25.999
5 40 1.538603894s 25.998
6 40 1.528344475s 26.172
7 40 1.537658908s 26.014
8 40 1.524533463s 26.238
9 40 1.530596854s 26.134
10 40 1.534065202s 26.075
11 40 1.527912898s 26.180
12 40 1.54139479s 25.951
13 40 1.527839524s 26.181
14 40 1.540419253s 25.967
15 40 1.52709141s 26.194
16 40 1.523726365s 26.251
17 40 1.537996435s 26.008
18 40 1.531848538s 26.112
19 40 1.529477388s 26.153
20 40 1.522877409s 26.266

Compare the results above with those for the default branch.

Base automatically changed from ole/push-owwkptqkmrvv to main February 12, 2026 16:10
@vapourismo vapourismo added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit 214b4ab Feb 13, 2026
7 checks passed
@vapourismo vapourismo deleted the ole/push-vtywzosmovko branch February 13, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants