refactor(durable-storage): categorise error types into operational and invalid arguments#814
Merged
vapourismo merged 1 commit intomainfrom Feb 13, 2026
Merged
Conversation
6f41606 to
c6434ae
Compare
8b4f061 to
0a7fd7a
Compare
c6434ae to
05a0f78
Compare
05a0f78 to
0b71447
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
- Coverage 91.10% 91.08% -0.02%
==========================================
Files 110 110
Lines 20913 20913
Branches 20913 20913
==========================================
- Hits 19052 19049 -3
- Misses 1488 1491 +3
Partials 373 373 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d53fc19 to
2edd59c
Compare
|
Benchmark results for revision 2dcf27f:
Full results
Compare the results above with those for the default branch. |
NSant215
reviewed
Feb 12, 2026
…d invalid arguments
2edd59c to
e14864c
Compare
NSant215
approved these changes
Feb 13, 2026
victor-dumitrescu
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactor and reduce the number of error types in the Durable Storage crate. All operational errors (not caused directly by the user) will surface as
OperationalError. Misuse errors will appear asInvalidArgumentError.Needed for #770.
Why
Improve the error situation in the Durable Storage crate per this thread.
Manually Testing
Tasks for the Author