feat(outbox): support getting outbox messages by level in node pvm#815
Draft
zcabter wants to merge 1 commit intovdum/rv-877from
Draft
feat(outbox): support getting outbox messages by level in node pvm#815zcabter wants to merge 1 commit intovdum/rv-877from
zcabter wants to merge 1 commit intovdum/rv-877from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vdum/rv-877 #815 +/- ##
===============================================
+ Coverage 91.16% 91.19% +0.02%
===============================================
Files 110 110
Lines 21206 21312 +106
Branches 21206 21312 +106
===============================================
+ Hits 19333 19436 +103
- Misses 1498 1501 +3
Partials 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8a3a56e to
301d866
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of RV-874
What
Exposes
get_outbox_messagesin theNodePvmWhy
This is required to enable the Rollup Node to query outbox messages for a specific level, which reflects the RPC endpoint that it will ultimately expose.
How
Exposes get_outbox_messages for use exclusively in Normal mode. It should never be invoked in code paths that require proof as it could potentially blow up proof size
Manually Testing
Regressions
Tasks for the Author