Don't assume brew is available in the system #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zordrak
previously approved these changes
Jul 4, 2025
Zordrak
force-pushed
the
fix/package-agnostic-dep-check
branch
2 times, most recently
from
965bf03 to
bd086f0
Compare
|
Tests are failing. Might get a colleague that has a Mac to look into why if I can - but test failure needs resolving before PR can be merged. |
All we care about is that GNU grep is available, which could've been installed in a number of ways, not just via Homebrew.
Zordrak
force-pushed
the
fix/package-agnostic-dep-check
branch
from
bd086f0 to
4695cb7
Compare
|
Hey @Zordrak, I think I've fixed the issue, see the commit message for the details. |
davidmh
force-pushed
the
fix/package-agnostic-dep-check
branch
from
760670e to
8b13235
Compare
When we find a brew-installed grep, we create an alias from ggrep to grep, but an alias can't be defined and used in the same parsing unit, so we exit early instead. See: https://www.shellcheck.net/wiki/SC2262
davidmh
force-pushed
the
fix/package-agnostic-dep-check
branch
from
8b13235 to
d57fdd5
Compare
|
@Zordrak I mistakenly used an You can see the diff here: https://github.com/tfutils/tfenv/compare/8b13235509c7521d9984c4a66f0b53262ea394de..d57fdd50b49a1c5852ce51f6f2ca1f3b15c83a60 Sorry for the thrash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a project that uses nix as a package manager through a flake file. I can add tfenv through a custom derivation, which can include the required gnugrep dependency in the definition.
But the project assumes that the GNU version would be installed with Homebrew, which might not be installed at all.
Since all we care about is that GNU grep is available, we should use
grep --versioninstead.