Conversation
- Identify the author as the github-actions bot (cherry picked from commit 75c6f3b)
Corrections on Manta M8P V2 spi pins
📝 WalkthroughWalkthroughUpdated BTT Manta M8P-20 board definition to remap software SPI pins for MOTOR1–MOTOR8 and stepperSPI from PC10/PC11/PC12 to PG6/PG7/PG8. Also standardized Git commit identity in three CI workflow files to use Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
configuration/boards/btt-manta-m8p-20/board-definition.json (1)
129-143:⚠️ Potential issue | 🔴 CriticalUpdate ADXL345SPI to use the correct SPI3A pins for the M8P V2.0.
The current ADXL345SPI configuration uses PC10/PC11/PC12 with CS on PB12, which corresponds to SPI3, not the correct SPI3A bus. According to the official Klipper reference configuration for the M8P V2.0, ADXL345 should use:
sclk: PG8mosi: PG6miso: PG7cs_pin: PA15Updated ADXL345SPI configuration
"ADXL345SPI": { "cs_pin": "PA15", "software": { "sclk": "PG8", "mosi": "PG6", "miso": "PG7" } }
Corrected diagrams for stock hardware and most used ones. EBB42 and all the octopus but Max EZ
e2ababf to
c85e928
Compare
Corrections on Manta M8P V2 spi pins
Corrected diagrams for stock hardware and most used ones. EBB42 and all the octopus but Max EZ
c85e928 to
c3c995f
Compare
Corrections on Manta M8P V2 spi pins
Summary by CodeRabbit