Skip to content

Fixes order of adding/removing reviewers from pr events #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LemonInTheDark merged 1 commit into from
Jun 5, 2026
Merged

Fixes order of adding/removing reviewers from pr events #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33225,19 +33225,30 @@ async function run() {
info('No reviewers to call');
return;
}
//Remove users that removed themselves from review
//Remove users that have previously removed/added themself to review
;
(await octokit.paginate(octokit.rest.issues.listEvents.endpoint.merge({
owner: core_owner,
repo: core_repo,
issue_number: pull_number
})))
.flatMap(array => array)
.reverse() //reverse to get latest events
.forEach(issue_event => {
if (issue_event.event == 'review_request_removed') {
const event = issue_event.event;
if (event == 'review_request_removed' ||
event == 'review_requested') {
const remove = issue_event.actor.login;
notice(`User ${remove} cannot be requested because they have removed themself as reviewer.`);
trimmed_owners.splice(trimmed_owners.indexOf(remove), 1);
//skip bot events
if (remove == 'github-actions[bot]') {
return;
}
//if user has triggered this event then we skip it
const index = trimmed_owners.indexOf(remove);
if (index >= 0) {
notice(`User ${remove} has ${event == 'review_request_removed' ? 'previously removed' : 'already added'} themself as a reviewer.`);
trimmed_owners.splice(index, 1);
}
}
});
//Remove Invalid users
Expand Down
27 changes: 21 additions & 6 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ async function run(): Promise<void> {
return
}

//Remove users that removed themselves from review
//Remove users that have previously removed/added themself to review
;(
await octokit.paginate<
RestEndpointMethodTypes['issues']['listEvents']['response']['data']
Expand All @@ -180,13 +180,28 @@ async function run(): Promise<void> {
)
)
.flatMap(array => array)
.reverse() //reverse to get latest events
.forEach(issue_event => {
if (issue_event.event == 'review_request_removed') {
const event = issue_event.event
if (
event == 'review_request_removed' ||
event == 'review_requested'
) {
const remove = issue_event.actor.login
notice(
`User ${remove} cannot be requested because they have removed themself as reviewer.`
)
trimmed_owners.splice(trimmed_owners.indexOf(remove), 1)

//skip bot events
if (remove == 'github-actions[bot]') {
return
}

//if user has triggered this event then we skip it
const index = trimmed_owners.indexOf(remove)
if (index >= 0) {
notice(
`User ${remove} has ${event == 'review_request_removed' ? 'previously removed' : 'already added'} themself as a reviewer.`
)
trimmed_owners.splice(index, 1)
}
}
})

Expand Down