Use font-size variable instead hardcoded number inside unit function#262
Open
AyIong wants to merge 3 commits into
Open
Use font-size variable instead hardcoded number inside unit function#262AyIong wants to merge 3 commits into
font-size variable instead hardcoded number inside unit function#262AyIong wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Replaces hardcoded font size value inside unit function, to calculated with css variable font-size value
Also adds function for extraction value from css variable
Why's this needed?
Font size can be changed so we need to take it actual inside functions