Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synced-lyrics): romanization #2790

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
aea5917
feat(synced-lyrics): init romanization!
ArjixWasTaken Dec 28, 2024
01f5c72
remove debug logs and add TODO
ArjixWasTaken Dec 28, 2024
8b5d1e0
feat(synced-lyrics/romanization): Mandarin!
ArjixWasTaken Dec 29, 2024
77f40e7
feat(synced-lyrics/romanization): improve japanese detection
ArjixWasTaken Dec 29, 2024
119020f
feat(synced-lyrics/romanization): Korean!
ArjixWasTaken Dec 29, 2024
507aac0
qol(synced-lyrics/romanization): canonicalize punctuation and symbols
ArjixWasTaken Dec 29, 2024
71f338d
feat(synced-lyrics/romanization): handle japanese+korean and korean+c…
ArjixWasTaken Jan 1, 2025
0a3c78a
revert formatting on electron.vite.config.mts
ArjixWasTaken Jan 1, 2025
691c482
feat(synced-lyrics/romanization): romanize plain lyrics
ArjixWasTaken Jan 5, 2025
611da35
apply fix by @kimjammer
ArjixWasTaken Jan 7, 2025
e47e9a3
fix lockfile due to rebase
ArjixWasTaken Mar 2, 2025
e294060
feat(synced-lyrics): improve lyric processing and formatting;
ArjixWasTaken Mar 2, 2025
2db4398
feat(synced-lyrics/romanization): add option to enable/disable romani…
ArjixWasTaken Mar 3, 2025
0643ada
chore: move default value for --lyrics-duration to the declaration
ArjixWasTaken Mar 3, 2025
c305367
Merge branch 'master' into synced-lyrics-romanization
ArjixWasTaken Mar 6, 2025
b45d265
Merge branch 'master' into synced-lyrics-romanization
ArjixWasTaken Mar 7, 2025
ac97bfd
Merge branch 'master' into synced-lyrics-romanization
ArjixWasTaken Mar 11, 2025
6923933
Merge branch 'th-ch:master' into synced-lyrics-romanization
ArjixWasTaken Mar 15, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions electron.vite.config.mts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { resolve, dirname, join } from 'node:path';
import { dirname, join, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';

import { UserConfig } from 'vite';
Expand Down Expand Up @@ -41,7 +41,17 @@ export default defineConfig({
ignoreDynamicRequires: true,
},
rollupOptions: {
external: ['electron', 'custom-electron-prompt', ...builtinModules],
external: [
'electron',
'custom-electron-prompt',
'kuromoji',
'kuroshiro',
'kuroshiro-analyzer-kuromoji',
'pinyin',
'segmentit',
'es-hangul',
...builtinModules,
],
input: './src/index.ts',
},
},
Expand Down
6 changes: 6 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@
"electron-store": "10.0.1",
"electron-unhandled": "4.0.1",
"electron-updater": "6.3.9",
"es-hangul": "^2.2.4",
"fast-average-color": "9.4.0",
"fast-equals": "5.2.2",
"filenamify": "6.0.0",
Expand All @@ -279,9 +280,14 @@
"jimp": "1.6.0",
"keyboardevent-from-electron-accelerator": "2.0.0",
"keyboardevents-areequal": "0.2.2",
"kuromoji": "^0.1.2",
"kuroshiro": "^1.2.0",
"kuroshiro-analyzer-kuromoji": "^1.1.0",
"node-html-parser": "7.0.1",
"node-id3": "0.2.8",
"peerjs": "1.5.4",
"pinyin": "4.0.0-alpha.2",
"segmentit": "^2.0.3",
"semver": "7.7.1",
"serve": "14.2.4",
"simple-youtube-age-restriction-bypass": "github:organization/Simple-YouTube-Age-Restriction-Bypass#v2.5.9",
Expand Down
Loading
Loading