Fixing filesystem paths in Envjs.uri #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e application will not start up)
…en you load Envjs
…ith var in the global namespace means it can't be deleted, if you declare something without var, you can delete the property. plus, there is no advantage to declaring with var
|
I have tested this patch locally on my Windows dev box and it worked great. This patch is critical if you are planning on running Jasmine and Jasmine-Species in a headless setup (outside the browser). Without it you will not be able to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests fixes 2 issues and adds a test for both:
If you put in an absolute windows path in any browser, like this: C:\foo\bar\index.html, it will convert it to file:///C:/foo/bar/index.html.
If you have document=null and you try to open a relative path, like this: specs/env/spec.html, Envjs tries to convert this to a file: URL. However, this wasn't working quite right in Windows beacuse getcwd() returns the wrong slash, and file:/// should have 3 slashes, not 2.