Detect in-place release asset re-uploads in update check - #204
Draft
DysektAI wants to merge 1 commit into
Draft
Conversation
Razzmatazzz
approved these changes
Aug 10, 2026
Member
|
Actually, rather than adding additional settings and complexity, I should probably just try harder to not fumble releases. |
Contributor
we are human, i think this is a good change to add, but i only glanced at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A hotfix re-published under an existing release tag currently leaves users silently running a replaced build: the update check only compares version numbers, and an in-place asset re-upload does not change the tag. This PR makes the update check also detect when the
TarkovMonitor.zipasset of the current release has been re-uploaded, so affected users get the existing "new version available" notification instead of nothing.Changes
UpdateCheck.cs— the check now reads the release'sassetspayload and compares theTarkovMonitor.zipasset'supdated_atagainst the last observed value. The baseline is seeded silently on first sighting, so fresh installs work. Notifies when:Properties/Settings.settings+Properties/Settings.Designer.cs— two new user-scoped string settings:lastSeenReleaseTagandlastSeenReleaseAssetUpdatedAtApp.config— mirrors the new settings under<userSettings>so the settings designer does not produce an unrelated regeneration diffBehavior notes
assetspayload never reads as a change and never poisons the stored baseline — the check falls back to the original version-only behavior.Settings.Save()is only called when the observed state actually changed (no daily redundant disk writes for users on an old version).Scope
4 files, +65/−2. No version bump, no new dependencies, no changes outside the update check.
Verification
dotnet build -t:Rebuild: 0 errors; the 4 pre-existing CS8618 warnings inUpdateCheck.csare untouched and the new code adds none-p:Version=<tag>override makeslocalVersion == remoteVersionhold exactly for real releases