Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template to require npm in non-SCL bundles #64

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Update template to require npm in non-SCL bundles #64

merged 1 commit into from
Apr 29, 2020

Conversation

zjhuntin
Copy link
Contributor

No description provided.

@zjhuntin
Copy link
Contributor Author

I'm not 100% sure if this is what is needed, but I'm going to test it. Figured others might know if it'd work on sight so, made the PR.

ehelms
ehelms reviewed Mar 18, 2020
View reviewed changes
@zjhuntin zjhuntin force-pushed the update_spec_template branch from 583b8de to 02a11f0 Compare March 18, 2020 17:50
@zjhuntin
Copy link
Contributor Author

http://koji.katello.org/koji/taskinfo?taskID=298770

Have it passing with this adjustment of just BuildRequires: npm

ekohl
ekohl reviewed Mar 18, 2020
View reviewed changes
@ekohl ekohl mentioned this pull request Apr 3, 2020
Merged
@zjhuntin zjhuntin force-pushed the update_spec_template branch from 02a11f0 to 604d729 Compare April 3, 2020 17:35
@ekohl ekohl mentioned this pull request Apr 29, 2020
Merged
ekohl
ekohl requested changes Apr 29, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have a look at my suggestion?

@zjhuntin zjhuntin force-pushed the update_spec_template branch from 604d729 to 8fe94ad Compare April 29, 2020 18:02
ehelms
ehelms reviewed Apr 29, 2020
View reviewed changes
@zjhuntin zjhuntin force-pushed the update_spec_template branch from 8fe94ad to 366d45c Compare April 29, 2020 18:13
@zjhuntin zjhuntin force-pushed the update_spec_template branch from 366d45c to 421d652 Compare April 29, 2020 18:14
@ekohl ekohl changed the title Update template to require npm and nodejs for updating specfiles. Update template to require npm in non-SCL bundles Apr 29, 2020
@ehelms ehelms merged commit bfcbb9d into theforeman:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms left review comments

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zjhuntin @ekohl @ehelms