migrate seone function in theme hook - #124
Open
robinallezard wants to merge 5 commits into
Open
Conversation
anoziere
reviewed
Jul 28, 2026
anoziere
left a comment
Contributor
There was a problem hiding this comment.
The decoupling goal makes sense, but the migration is partial and there is a site-wide title regression.
base.html.twigstill opens with{% set breadcrumb = SEOneBreadcrumb() %}, an unconditional module call in the base layout. Without SEOne installed, every page fatals on an unknown function. Same problem inindex.html.twig(SEOneWebSite(),SEOneWebPage(),SEOneLocalBusiness()),category.html.twig(SEOnePageH1()), the Product component, andcontact.html.twig. As long as those remain, the theme still hard-depends on the module.- The
<title>{% block title %}...{% endblock %}</title>wrapper was removed frombase.html.twig, but ~27 templates still defineblock title. Twig silently discards all of them, so no page renders a title tag anymore. The og:title/og:url/og:type/twitter meta defaults went away with it, and it's not obvious the hook side replaces them exactly. src/EventListener/SeoListener.phpships four empty no-op methods, subscribes toSEOnePageh1Eventwhile importingSEOnePageH1Event(case mismatch), and assignsgetCurrentRequest()(nullable) to a non-nullable readonlyRequestproperty, which will throw outside an HTTP context.- The
addPseToCartbrowser event and theSimilarContentexclude filter look unrelated to the SEOne migration; splitting them out would keep this PR easier to review.
Worth reviewing together with thelia-modules/SEOne#11 since the two halves have to land in a consistent state.
anoziere
self-requested a review
July 28, 2026 13:08
robinallezard
force-pushed
the
feat/seone-theme-hook
branch
from
July 31, 2026 13:11
77c110e to
c5a1277
Compare
Collaborator
Author
|
1er point => Seone étant dans thelia-skeleton c'est normal qu'on est un couplage fort entre le module et le theme 2ème point => corrigé avec la nouvelle stratégie du module SEOne ( solution avec theme_hook et block twig) les autres points sont liés à d'autres corrections apporté suite à la migration de GTM et recaptcha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SEOne commit relative