-
Notifications
You must be signed in to change notification settings - Fork 78
✨ Certificate added to course bundles #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted Certificate, CertificateCard, CertificateEmptyState, and CertificatePreviewModal components from the course builder. This change likely reflects a refactor or removal of certificate-related functionality from the course builder UI.
Introduces Certificate, CertificateCard, and CertificateEmptyState components for managing certificate templates and custom certificates. Also adds CertificatePreviewModal for previewing and selecting certificates within a modal dialog.
Replaces the local Certificate interface definition with an imported type from another module to improve type consistency and reduce duplication.
Introduces a new Certificate interface to define the structure for certificate objects, including fields for name, orientation, URLs, preview, background, key, and optional properties. This will help standardize certificate data usage across the application.
Moved Certificate import to shared components and updated its usage to pass currentCertificateKey, onSelect handler, and certificateTemplates props. This enables certificate selection and template management in the Additional page.
Extended get_courses_by_user and get_active_courses_by_user to accept an $args parameter for overriding default query arguments. Added related filters and standardized post_type assignment for improved extensibility and consistency.
shewa12
approved these changes
Oct 8, 2025
classes/Utils.php
Outdated
* | ||
* @return bool|\WP_Query | ||
*/ | ||
public function get_courses_by_user( $user_id = 0, $offset = 0, $posts_per_page = -1 ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to refactor this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Certificate import to shared components and updated its usage to pass currentCertificateKey, onSelect handler, and certificateTemplates props. This enables certificate selection and template management in the Additional page.