fix(migrations): watch the migrations out_dir in build::Config::watch - #58
Merged
Conversation
The previous-snapshot chain under out_dir is a diff input: deleting or reverting a migration folder changes what build::run generates. Without watching it, cargo sees no changed path, skips the build script, and replays the cached output — the migration is silently never regenerated. Cargo scans watched directories recursively and treats a not-yet-existing path as changed, so the first run (which creates the directory) converges. Watch targets are split into an assertable watch_targets() helper with tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config::watchnow emitscargo:rerun-if-changedfor the migrations output directory in addition to the schema files and TOML config. The previous-snapshot chain underout_diris a diff input: deleting or reverting a migration folder changes whatbuild::rungenerates, but without the watch cargo skips the build script and replays cached output — the migration is silently never regenerated. Cargo scans watched directories recursively and treats a not-yet-existing path as changed, so the first run (which creates the directory) converges.Watch targets are refactored into an assertable
watch_targets()helper with tests.Test plan
watch_targets_*unit testscargo test -p drizzle-migrations🤖 Generated with Claude Code