feat: conditionally hide cloud storage filter in song picker#2015
Merged
theovilardo merged 1 commit intoMay 16, 2026
Merged
Conversation
Updates the `SongPickerBottomSheet` to dynamically hide storage filter tabs if no cloud-based songs are present in the library. When cloud content is unavailable, the UI replaces the filter row with a simplified confirmation floating action button. - Added `getCloudSongCountFlow` to `MusicDao` and `MusicRepository` to monitor cloud-sourced media. - Implemented `hasCloudSongsFlow` in `PlayerViewModel` to expose the presence of cloud content as a `StateFlow`. - Updated `SongPickerBottomSheet` to conditionally render the storage toggle and adjust layout padding based on cloud song availability. - Added a `LaunchedEffect` to reset the storage filter to `OFFLINE` if cloud content is missing. - Commented out the AI generation button in `CreatePlaylistScreen`.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Restore the AI generation entry point
When creating a playlist, CreatePlaylistDialog still passes a real onGenerateClick callback into this form, but this block is now commented out so no visible control invokes it. In the create flow, users can no longer launch the AI playlist generator; either keep the button or provide another entry point before removing this block.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
SongPickerBottomSheetto dynamically hide storage filter tabs if no cloud-based songs are present in the library. When cloud content is unavailable, the UI replaces the filter row with a simplified confirmation floating action button.getCloudSongCountFlowtoMusicDaoandMusicRepositoryto monitor cloud-sourced media.hasCloudSongsFlowinPlayerViewModelto expose the presence of cloud content as aStateFlow.SongPickerBottomSheetto conditionally render the storage toggle and adjust layout padding based on cloud song availability.LaunchedEffectto reset the storage filter toOFFLINEif cloud content is missing.CreatePlaylistScreen.