refactor: optimize album color scheme generation and caching#2017
Merged
Conversation
Improves the efficiency of `ThemeStateHolder` by allowing multiple subscribers to wait for the same color scheme generation request. Also increases the LRU cache capacity to improve performance when navigating through large libraries. - Replaced the simple `pendingAlbumColorSchemeRequests` set with a synchronized `pendingAlbumColorSchemeTargets` map to track and update multiple `MutableStateFlow` instances for a single URI. - Increased `individualAlbumColorSchemes` LRU cache size from 30 to 96 entries. - Added validation to handle blank URI strings, returning a static `emptyAlbumColorScheme` flow. - Improved thread safety by using a dedicated lock for pending request operations and updated `onTrimMemory` accordingly. - Cleaned up unused `ConcurrentHashMap` import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the efficiency of
ThemeStateHolderby allowing multiple subscribers to wait for the same color scheme generation request. Also increases the LRU cache capacity to improve performance when navigating through large libraries.pendingAlbumColorSchemeRequestsset with a synchronizedpendingAlbumColorSchemeTargetsmap to track and update multipleMutableStateFlowinstances for a single URI.individualAlbumColorSchemesLRU cache size from 30 to 96 entries.emptyAlbumColorSchemeflow.onTrimMemoryaccordingly.ConcurrentHashMapimport.