fix: improve audio focus handling and seek position accuracy#2021
Merged
Conversation
Refines audio focus management in `DualPlayerEngine` to prevent contention races and support delayed gain. Updates `PlaybackStateHolder` to fix UI "snap-back" during backward seeks and adds a timeout for stale position overrides. - Retain audio focus during user-initiated pauses to avoid re-acquisition races. - Support `AUDIOFOCUS_REQUEST_DELAYED` in `DualPlayerEngine`. - Implement a 4-second expiration for paused position overrides in `PlaybackStateHolder`. - Fix a bug where backward seeks while paused would prematurely revert to the old position. - Clean up reset logic for position overrides and cold-start snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines audio focus management in
DualPlayerEngineto prevent contention races and support delayed gain. UpdatesPlaybackStateHolderto fix UI "snap-back" during backward seeks and adds a timeout for stale position overrides.AUDIOFOCUS_REQUEST_DELAYEDinDualPlayerEngine.PlaybackStateHolder.