fix: prevent audio HAL-reset heuristic from misinterpreting user seeks#2022
Merged
Conversation
Prevents the `DualPlayerEngine` from incorrectly identifying a manual seek as a HAL offload underflow. By tracking seek timing, the engine now distinguishes between legitimate audio-sink resets and standard buffering caused by position changes, avoiding unnecessary player rebuilds that could drop pending commands. - Added `lastSeekAtMs` to track the timestamp of the most recent seek operation. - Implemented `notifyExternalSeekInitiated()` to allow the UI to flag seeks synchronously before they are dispatched to the `MediaController`. - Updated `onPlaybackStateChanged` logic to ignore `STATE_BUFFERING` events if they occur within a 1.5-second window of a seek. - Added `onPositionDiscontinuity` listener to capture and record seek events within the player engine. - Integrated the seek notification call in `PlaybackStateHolder` immediately prior to executing `seekTo`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the
DualPlayerEnginefrom incorrectly identifying a manual seek as a HAL offload underflow. By tracking seek timing, the engine now distinguishes between legitimate audio-sink resets and standard buffering caused by position changes, avoiding unnecessary player rebuilds that could drop pending commands.lastSeekAtMsto track the timestamp of the most recent seek operation.notifyExternalSeekInitiated()to allow the UI to flag seeks synchronously before they are dispatched to theMediaController.onPlaybackStateChangedlogic to ignoreSTATE_BUFFERINGevents if they occur within a 1.5-second window of a seek.onPositionDiscontinuitylistener to capture and record seek events within the player engine.PlaybackStateHolderimmediately prior to executingseekTo.