Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old graphics api with Porthole #823

Draft
wants to merge 16 commits into
base: theseus_main
Choose a base branch
from
Draft

Replace old graphics api with Porthole #823

wants to merge 16 commits into from

Conversation

ouz-a
Copy link
Contributor

@ouz-a ouz-a commented Jan 22, 2023 •
edited
Loading

Longer comment will be here

Adds on top of what's built on #722, replaces entire graphics api with Porthole

Tasks:

  • Open the PR
  • Clean the code
  • Create documentation
  • Replace book's chapter on graphics with new one

@kevinaboos kevinaboos marked this pull request as draft January 24, 2023 01:10
@kevinaboos kevinaboos mentioned this pull request Jan 24, 2023
Closed
8 tasks
kevinaboos
kevinaboos requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to submit this review, sorry. Some things may have already been addressed.

kernel/porthole/src/window.rs Outdated Show resolved Hide resolved
kernel/porthole/src/window.rs Outdated Show resolved Hide resolved
kernel/porthole/src/window.rs Outdated Show resolved Hide resolved
kernel/porthole/src/framebuffer.rs Outdated Show resolved Hide resolved
kernel/porthole/src/lib.rs Outdated Show resolved Hide resolved
@ouz-a ouz-a force-pushed the port-1 branch 3 times, most recently from 56af037 to 288b523 Compare February 15, 2023 11:08
ouz-a and others added 15 commits February 15, 2023 20:42
@hecatia-elegua hecatia-elegua mentioned this pull request May 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinaboos kevinaboos kevinaboos requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ouz-a @kevinaboos