Implement tBTC Bridge fees reimbursement #942
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For deposits below a certain threshold, the fees will be reimbursed from the fees reimbursement pool, funded by the Acre protocol. The tBTC Bridge fees reimbursement threshold can be updated by the Acre protocol owner.
✅ Deploy Preview for acre-dapp-testnet canceled.
|
✅ Deploy Preview for acre-dapp canceled.
|
pdyraga
reviewed
May 5, 2025
| address _tbtcToken, | ||
| address _bitcoinDepositor | ||
| ) external initializer { | ||
| __Ownable2Step_init(); |
There was a problem hiding this comment.
I think we should be good not calling it at all, given it does nothing, but if you want to make it more future-proof, this could make sense.
| @@ -177,6 +195,9 @@ contract BitcoinDepositor is AbstractTBTCDepositor, Ownable2StepUpgradeable { | |||
|
|
|||
| minDepositAmount = 0.015 * 1e18; // 0.015 BTC | |||
| depositorFeeDivisor = 1000; // 1/1000 == 10bps == 0.1% == 0.001 | |||
|
|
|||
| // Disable fees reimbursement by default. | |||
| bridgeFeesReimbursementThreshold = 0; | |||
There was a problem hiding this comment.
Are we deploying a new BitcoinDepositor contract or upgrading the existing one? For this line it does not make a lot of difference as the default value is 0 but I want to understand the flow.
r-czajkowski
reviewed
May 8, 2025
Comment on lines
+49
to
+57
| uint256 availableBalance = IERC20(tbtcToken).balanceOf(address(this)); | ||
|
|
||
| if (availableBalance < reimbursedAmount) { | ||
| reimbursedAmount = availableBalance; | ||
| } | ||
|
|
||
| if (reimbursedAmount > 0) { | ||
| IERC20(tbtcToken).safeTransfer(msg.sender, reimbursedAmount); | ||
| } |
There was a problem hiding this comment.
Because there is some logic to calculate the reimbursed amount (I mean, in some cases the full amount cannot be covered), maybe we can create a view function so we can call it in SDK and use it in this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For deposits below a certain threshold, the fees will be reimbursed from the fees reimbursement pool, funded by the Acre protocol.
The tBTC Bridge fees reimbursement threshold can be updated by the Acre protocol owner.
TODO: