-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: python-tuf version should be visible in docs (readthedocs) #1568
Comments
Why not activating a version build from a tag? https://theupdateframework.readthedocs.io/en/v0.18.1/ I had to manually go to Versions and click the "Activate" button. |
Yeah that helps... At least from release notes and such we can link to specific versions. https://docs.readthedocs.io/en/stable/automation-rules.html shows that we can make the activation automatic as well: I'll try it. So maybe it doesn't matter that https://theupdateframework.readthedocs.io/en/latest/ doesn't say anywhere which version it is? |
|
Right, I meant "stable" as the problematic one (but would be nice if "latest" was clearly marked as git version as well). |
Just found the corresponding upstream issue: readthedocs/readthedocs.org#4529. |
hey I'm interested to work in this issue is this still open!! |
Sure, thanks. https://www.sphinx-doc.org/en/master/usage/configuration.html says that variable Maybe you can just |
i get an attribute error tuf has no attribute version |
Please link to a branch with the changes (that do not work) if you'd like someone to have a look |
@jku |
I mentioned this a few posts up:
Results in docs/build if I recall correctly |
@jku |
You don't mention what changed so I don't know... but if docs build from 'develop' does not include the version and a build with your change does, then that seems like a good sign that it will work similarly on readthedocs. Feel free to do a PR so we get a docs build on readthedocs. Possible further improvements:
You can not fix the second issue (it's a release process fix), but if you want you can try the first one. It's not required though, a PR with the version setting is fine. |
@jku i have raised a pull request. kindly review it. |
fixes #1568 Include python-tuf version in documentation
I'm reopening: The change seems fine but readthedocs does something on their end that hides this change https://theupdateframework.readthedocs.io/en/latest/index.html I think we can still try using the version in the actual documentation content: if that doesn't work then this is just not worth this much work. |
Hey @jku, Am totally new here don't know how to work on this issue,but want to contribute (getting started ). So can you please guide me. Thank you !!! |
https://theupdateframework.readthedocs.io/en/stable/ works great and automatically updates based on release tags.
But it's hard to see which release the docs are actually for...
I'm not sure if the solution is to build the version number into the main documentation page, or if there's a readthedocs feature we could use to have the tag name visible in the UI?
The text was updated successfully, but these errors were encountered: