Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1568 added import tuf and version = tuf.__version__ in conf.py #2199

Closed
wants to merge 1 commit into from

Conversation

gkum99
Copy link
Contributor

@gkum99 gkum99 commented Nov 28, 2022

Signed-off-by: gkum99 [email protected]

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes #1568

Description of the changes being introduced by the pull request:
Added import tuf and version = tuf.version in conf.py

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Signed-off-by: gkum99 <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3566014164

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.189%

Totals Coverage Status
Change from base Build 3563400725: 0.0%
Covered Lines: 1346
Relevant Lines: 1362

💛 - Coveralls

@jku
Copy link
Member

jku commented Nov 28, 2022

Annoyingly readthedocs seems to overwrite version in the PR doc builds (https://theupdateframework--2199.org.readthedocs.build/en/2199/) with the PR number... so the build result doesn't actually tell us if this works 😂 we'll just have to assume it does

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code change probably works: let's try that. But your current commit message is

“fixes

Please replace that with a descriptive one, for example Include python-tuf version in documentation. You can force push the PR branch we don't mind that.

Optionally you could also move your code changes next to the other project information (copyright, author etc) where it makes sense -- but I can live without that change.

@gkum99 gkum99 closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: python-tuf version should be visible in docs (readthedocs)
3 participants