Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FA (future annotations) linting ruleset #2795

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

pakagronglb
Copy link
Contributor

We already use future annotations (from __future__ import annotations) in most of the codebase. This change enables the FA linting ruleset to ensure consistent usage across all files by:

  1. Removing "FA" from the ruleset ignore list in pyproject.toml
  2. Running linter checks with tox -e lint to verify compliance
  3. Running full test suite with tox to ensure no regressions

The linter passes without any FA-related issues, confirming that our codebase already follows the future annotations best practices consistently.

Testing:

  • ✓ Ran tox -e lint - all checks passed
  • ✓ Ran full test suite with tox - all tests passed

@pakagronglb pakagronglb requested a review from a team as a code owner February 19, 2025 11:47
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

  • This project requires a signed-off-by line in the commit message (sorry, CNCF requires that): feel free to do a git commit --amend --signoff and a force push. More info.
  • left a question about a docstring change

Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@jku jku linked an issue Feb 19, 2025 that may be closed by this pull request
@jku jku merged commit 9c67e27 into theupdateframework:develop Feb 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable FA (future annotations) linting ruleset
2 participants