Return 50 playlistItems from Youtube playlist info

[azelenets]

By default Youtube returns only 5 playlistItems from playlist. Propose to set max value.
https://developers.google.com/apis-explorer/#p/youtube/v3/youtube.playlistItems.list?part=snippet%252CcontentDetails&playlistId=PLBCF2DAC6FFB574DE&_h=2&

https://developers.google.com/youtube/v3/code_samples/code_snippets

[vheuken]

Thanks for the PR! I am unfortunately rather busy. I will do my best to look at it this week.

…

On Jul 17, 2017 4:04 AM, "Andrew Zelenets" ***@***.***> wrote: By default Youtube returns only 5 playlistItems from playlist. Propose to set max value. https://developers.google.com/apis-explorer/#p/youtube/v3/ youtube.playlistItems.list?part=snippet%252CcontentDetails&playlistId= PLBCF2DAC6FFB574DE&_h=2& https://developers.google.com/youtube/v3/code_samples/code_snippets ------------------------------ You can view, comment on, or merge this pull request online at: #175 Commit Summary - Return 50 playlistItems from playlist info File Changes - *M* lib/video_info/providers/youtubeplaylist_api.rb <https://github.com/thibaudgg/video_info/pull/175/files#diff-0> (2) Patch Links: - https://github.com/thibaudgg/video_info/pull/175.patch - https://github.com/thibaudgg/video_info/pull/175.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#175>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAs5GGdZgKItZEoKJdGl_R0zYDKOEDI7ks5sOz-hgaJpZM4OZ0uc> .

[azelenets]

Thanks a lot, your gem is very useful.

[coveralls]

Coverage remained the same at 100.0% when pulling 4d0e4dd on azelenets:patch-1 into 10c3fd8 on thibaudgg:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 4d0e4dd on azelenets:patch-1 into 10c3fd8 on thibaudgg:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 4d0e4dd on azelenets:patch-1 into 10c3fd8 on thibaudgg:master.

[vheuken]

Sorry about taking so long to look at this. Is there any reason you set it to 50 in particular?

[azelenets]

the reason was that 50 is max, but more flexible solution is create some var in gem config (smth like youtube_max_results)

[markets]

@thibaudgg after reviewing the docs:

I think this change makes sense... ideally should be configurable, but for now I'd just merge it (at least you can filter out results later).

[thibaudgg]

@markets isn't already like that on master with the ITEMS_MAX_RESULTS constant? https://github.com/thibaudgg/video_info/blob/master/lib/video_info/providers/youtubeplaylist_api.rb#L3

I think we can close that one no?

[markets]

Ah yes! Then we can close this pull request and probably the issue #171.

[thibaudgg]

Already fixed by e23699e