Temporary/throwaway PR to recheck that the resource warning for DB reuse is still active with current version #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
- Coverage 99.34% 99.12% -0.22%
==========================================
Files 3 3
Lines 455 458 +3
==========================================
+ Hits 452 454 +2
- Misses 3 4 +1 ☔ View full report in Codecov by Sentry. |
mbhutton
force-pushed
the
temp/do-reuse-db-connection
branch
3 times, most recently
from
26bbbb4 to
b3badf7
Compare
mbhutton
force-pushed
the
temp/do-reuse-db-connection
branch
from
b3badf7 to
0b26463
Compare
|
|
Closing this PR in favour of a better approach using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before committing to backing out that connection reuse commit, reassert that the CI test failure is still active with the current version of Python, things.py, and its dependencies.
If this still fails tests in CI, I'll delete/discard this PR. Otherwise, I'll suggest leaving the connection reuse commit in place.