Code

Adding Reminder time#133

Code

Merged

mikez merged 12 commits intothingsapi:mainthingsapi/things.py:mainfrom

HiJohnElliott:reminder_timeHiJohnElliott/things.py:reminder_timeCopy head branch name to clipboard

Apr 1, 2025

Commits

Commits on Mar 14, 2025

• Added first batch of changes to add reminder_time as a returned value. This includes a new convert_thingstime_sql_expression_to_isotime() function, additions to the make_tasks_sql_query function, a…

  Show description for 1b4c474
  HiJohnElliott

  committed
  1b4c474

  Copy full SHA for 1b4c474

Commits on Mar 15, 2025

• fix bit mask on convert_thingstime... function to return accurate results.

  HiJohnElliott

  committed
  933f848

  Copy full SHA for 933f848

Commits on Mar 17, 2025

• re-added and finalized reminder_time value to make_tasks_sql_query

  HiJohnElliott

  committed
  9bca1d3

  Copy full SHA for 9bca1d3

Commits on Mar 18, 2025

• Deleted extra line at the bottom of the file.

  HiJohnElliott

  committed
  947da5f

  Copy full SHA for 947da5f

Commits on Mar 25, 2025

• Added function test_thingstime() to verify the return of the correct sql expression

  HiJohnElliott

  committed
  5b32c12

  Copy full SHA for 5b32c12

• Cleaned up commented lines.

  HiJohnElliott

  committed
  8441a56

  Copy full SHA for 8441a56

Commits on Mar 28, 2025

• This commit includes changes to all of the proposed improvements from the previous pull request as well as an updated version of the test_thingstime() function that only checks a single task in the…

  Show description for 9c48cb5
  HiJohnElliott

  committed
  9c48cb5

  Copy full SHA for 9c48cb5

Commits on Mar 30, 2025

• Removed the Sun Mar 30 10:15:10 CDT 2025 and SQL functions from make_tasks_sql_query() where they were wrapping the deadline, start_date, and reminder_time expressions. FIX: This commit also fixes…

  Show description for 95ec495
  HiJohnElliott

  committed
  95ec495

  Copy full SHA for 95ec495

• This commit removes new line characters from the description of and fixes the input and output in the same description. It is also includes a change in test_things.py to the function such that th…

  Show description for fda3db9
  HiJohnElliott

  committed
  fda3db9

  Copy full SHA for fda3db9

Commits on Apr 1, 2025

• This push includes changes to the docstring for to make sure it shows the correct inputs and outputs in the examples and also fits better stylistically. It also includes a change to to ensure tha…

  Show description for 941bf90
  HiJohnElliott

  committed
  941bf90

  Copy full SHA for 941bf90

• minor style tweaks

  Show description for 5c2d91d
  mikez

  committed
  5c2d91d

  Copy full SHA for 5c2d91d

• remove extra whitespace

  mikez

  committed
  b336967

  Copy full SHA for b336967