Fix: Replace tl.range flatten with Python range for Triton 3.x compatibility#19
Open
Jah-yee wants to merge 4 commits into
Open
Fix: Replace tl.range flatten with Python range for Triton 3.x compatibility#19Jah-yee wants to merge 4 commits into
Jah-yee wants to merge 4 commits into
Conversation
- Add comprehensive tests in tests/test_batch_invariant_ops.py - Fix mean_dim to handle empty dimension (return zeros instead of NaN) Good day, Thank you for your work on this excellent library! Warmly, RoomWithOutRoof
Added softmax along with log_softmax, expanding batch-invariant operations. Good day! Warmly, RoomWithoutRoof
Fixes Issue thinking-machines-lab#15: Fix NaN in mean_kernel for empty dimension When the reduction dimension is empty (N==0), return 0 to avoid NaN. Good day! Warmly, RoomWithoutRoof
…ibility The flatten parameter was removed in Triton 3.x public release. This changes tl.range(..., flatten=True) to Python's built-in range(), which works inside @triton.jit functions and is compatible with all versions. Fixes: TypeError: range.__init__() got an unexpected keyword argument 'flatten'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR fixes Issue #14: Incompatible with all public PyTorch/Triton releases.
Problem
The library cannot be used with any publicly available PyTorch/Triton combination due to the parameter in tl.range() being removed before the Triton 3.x public release.
Root Cause
The code used tl.range(..., flatten=True) which was available only in internal/nightly Triton builds but never shipped in any public release.
Solution
Replace tl.range(..., flatten=True) with Python's built-in range():
Testing
Related
Fixes: TypeError: range.init() got an unexpected keyword argument 'flatten'
Thank you for your work on this excellent library!
Warmly, RoomWithOutRoof