Add requirements.txt for project dependencies#5
Open
Jah-yee wants to merge 2 commits intothinking-machines-lab:mainfrom
Open
Add requirements.txt for project dependencies#5Jah-yee wants to merge 2 commits intothinking-machines-lab:mainfrom
Jah-yee wants to merge 2 commits intothinking-machines-lab:mainfrom
Conversation
added 2 commits
April 15, 2026 20:22
- test_msign.py: Add unit tests for msign matrix sign function - test_manifold_muon.py: Add unit tests for manifold muon optimizer - test_hyperspherical_descent.py: Add unit tests for hyperspherical descent
Good day, Thank you for your work on this excellent library! Warmly, RoomWithOutRoof
Jah-yee
pushed a commit
to Jah-yee/manifolds
that referenced
this pull request
Apr 15, 2026
Added: - requirements.txt with core and dev dependencies - tests/test_manifold_muon.py with basic tests Reference: Issues thinking-machines-lab#5, thinking-machines-lab#6 Good day! Warmly, RoomWithoutRoof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies Added
Summary
Added a requirements.txt file to properly declare project dependencies instead of having them hardcoded in the source files.
Good day,
Thank you for your work on this excellent library!
Warmly,
RoomWithOutRoof