Write rollout traces to summaries#748
Open
derek-tml wants to merge 4 commits into
Open
Conversation
This was referenced Jun 1, 2026
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
Author
|
@claude review |
Contributor
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
dphuang2
reviewed
Jun 4, 2026
Comment on lines
56
to
72
| def _json_safe(value: Any) -> Any: | ||
| """Convert values to JSON-serializable form.""" | ||
| if value is None or isinstance(value, (str, bool, int, float)): | ||
| return value | ||
| if is_dataclass(value) and not isinstance(value, type): | ||
| return _json_safe({k: v for k, v in asdict(value).items() if v is not None}) | ||
| if isinstance(value, dict): | ||
| return {str(k): _json_safe(v) for k, v in value.items()} | ||
| if isinstance(value, (list, tuple)): | ||
| return [_json_safe(v) for v in value] | ||
| if hasattr(value, "item"): | ||
| item = getattr(value, "item", None) | ||
| if item is not None: | ||
| try: | ||
| return value.item() | ||
| return item() | ||
| except Exception: | ||
| logger.debug("Failed to convert %r via .item(), falling back to str()", type(value)) | ||
| return str(value) |
Collaborator
There was a problem hiding this comment.
this whole thing looks like something Pydantic would solve
dphuang2
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RolloutTracedataclass for structured per-step transcript data.StepResult.traceintoTransition.trace.steps[].traceandsteps[].stop_reasoninto rollout summary JSONL records.Stack from ghstack (oldest at bottom):
Co-authored-by: Cursor cursoragent@cursor.com