fix: use api_checkpoint_id for sampler_weights loading#35
Open
Jah-yee wants to merge 1 commit intothinking-machines-lab:mainfrom
Open
fix: use api_checkpoint_id for sampler_weights loading#35Jah-yee wants to merge 1 commit intothinking-machines-lab:mainfrom
Jah-yee wants to merge 1 commit intothinking-machines-lab:mainfrom
Conversation
- Added api_checkpoint_id property to ParsedCheckpointTinkerPath - For training checkpoints: returns just the checkpoint number (e.g., '0001') - For sampler checkpoints: returns prefixed ID (e.g., 'sampler_weights/0001') - Updated rest_client.py to use api_checkpoint_id instead of checkpoint_id
Author
|
Good day 👋 Just a gentle bump on this PR! This fix adds support for using api_checkpoint_id when loading sampler_weights, which should improve the checkpoint loading flow. Would love to get your thoughts or review when you have a moment! Thank you for your work and happy coding! 🚀 Warmly, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Fixes Issue #25:
sampler_weightsnot available whileweightsis availableSummary
When loading a
sampler_weightscheckpoint using a tinker path (e.g.,tinker://run-id/sampler_weights/0001), the checkpoint loading fails with a "Path is invalid" error.Root Cause
In
ParsedCheckpointTinkerPath.from_tinker_path(), thecheckpoint_idwas including the type prefix (e.g.,sampler_weights/0001), but the API expected different formats for training vs sampler checkpoints.Fix
Added a new
api_checkpoint_idproperty toParsedCheckpointTinkerPath:0001)sampler_weights/0001)Updated
rest_client.pyto useapi_checkpoint_idinstead ofcheckpoint_idTesting
Added tests for parsing both checkpoint types.
Thank you for your work on this excellent library!
Warmly,
RoomWithOutRoof