Skip to content

Conversation

@thinkst-pieter
Copy link
Contributor

@thinkst-pieter thinkst-pieter commented Jan 9, 2026

Proposed changes

When a docker container restarts the twisted pid could be left in a dangling state preventing twisted from starting correctly.

This pull request fixes the stale pid issue by having the pid file in /var/run and the mounting /run as a temporary file system in the docker environment. This fix is in line with the solution we made for our commercial canary offering.

Additionally the github runners for macos are updated and a couple of documentation changes.

Types of changes

What types of changes does your code introduce to this repository?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes (if applicable)
  • I have run pre-commit (pre-commit in the repo)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Linked to the relevant github issue or github discussion

@thinkst-pieter thinkst-pieter marked this pull request as ready for review January 12, 2026 06:21
@thinkst-pieter thinkst-pieter merged commit db4ff1c into master Jan 12, 2026
31 checks passed
@thinkst-pieter thinkst-pieter deleted the Fix-docker-failure-with-dangling-pid-file branch January 12, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants