Skip to content

Enhance Solana transaction support and add new dependencies #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 6, 2025
Merged

Enhance Solana transaction support and add new dependencies #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92871e4
Enhance Solana transaction support and add new dependencies
d4mr Nov 4, 2025
fb90893
Add Solana RPC cache support in server
d4mr Nov 5, 2025
e2ba31d
add integration testing infra
d4mr Nov 6, 2025
3ec65f9
use spl interface
d4mr Nov 6, 2025
a744ac5
fix deps
d4mr Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 43 additions & 6 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ members = [
"solana-core",
"thirdweb-core",
"twmq",
"integration-tests",
]
resolver = "2"

Expand All @@ -28,7 +29,9 @@ solana-transaction-status = "3.0"
solana-connection-cache = "3.0"
solana-commitment-config = "3.0"
solana-compute-budget-interface = "3.0"
solana-system-interface = { version = "2.0", features = ["bincode"] }
spl-memo-interface = "2.0"
spl-token-2022-interface = "2.1"

# AWS
aws-config = "1.8.2"
Expand Down
2 changes: 2 additions & 0 deletions integration-tests/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/target
*local.yaml
44 changes: 44 additions & 0 deletions integration-tests/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
[package]
name = "engine-integration-tests"
version = "0.1.0"
edition = "2024"

[lib]
test = false # Don't build unit test harness for src/lib.rs etc.
doctest = false # Don't run doc tests for the library

[dependencies]
anyhow = { workspace = true }
tokio = { workspace = true, features = ["full"] }
tracing = { workspace = true }
tracing-subscriber = { workspace = true, features = ["env-filter"] }
serde = { workspace = true }
serde_json = { workspace = true }
base64 = { workspace = true }
bincode = { workspace = true }
moka = { workspace = true }
reqwest = { workspace = true, features = ["json"] }
prometheus = { workspace = true }
config = { workspace = true }

# Solana dependencies
solana-sdk = { workspace = true, features = ["full"] }
solana-client = { workspace = true }
solana-system-interface = { workspace = true }
spl-token-2022-interface = { workspace = true }

# Vault/Engine dependencies
vault-sdk = { workspace = true }
vault-types = { workspace = true }
engine-solana-core = { path = "../solana-core" }
engine-core = { path = "../core" }
engine-executors = { path = "../executors" }
thirdweb-core = { path = "../thirdweb-core" }
Comment on lines +33 to +36
Copy link

@coderabbitai coderabbitai bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify that all local path dependencies exist.

Lines 33–36 specify local path dependencies pointing to sibling directories (../solana-core, ../core, ../executors, ../thirdweb-core). Confirm that these relative paths are correct and the corresponding crates exist in the repository before merging.

🏁 Script executed:

#!/bin/bash
# Description: Verify that all local path dependencies exist in the repository.

# Check each path dependency
paths=(
  "solana-core"
  "core"
  "executors"
  "thirdweb-core"
)

for path in "${paths[@]}"; do
  if [ -d "../$path" ]; then
    echo "✓ Found: ../$path"
  else
    echo "✗ Missing: ../$path"
  fi
done

# Also verify from repo root
echo ""
echo "Verifying from repository root:"
fd -t d 'Cargo.toml$' -x dirname {} \; | head -20

Length of output: 129

I need to map the actual repository structure to verify the path dependencies. Let me run a comprehensive check from the repository root.

🏁 Script executed:

#!/bin/bash
# Description: Map repository structure and locate all crates

echo "=== Repository structure from root ==="
fd -t d -L 1 | sort

echo ""
echo "=== Location of integration-tests ==="
fd -t d 'integration-tests$' -x dirname {} \;

echo ""
echo "=== All Cargo.toml files in repository ==="
fd -t f 'Cargo.toml$' | sort

echo ""
echo "=== Checking if sibling crates exist at root level ==="
for crate in solana-core core executors thirdweb-core; do
  if [ -d "$crate" ] && [ -f "$crate/Cargo.toml" ]; then
    echo "✓ Found crate: $crate/"
  else
    echo "✗ Missing crate: $crate/"
  fi
done

Length of output: 506

The relative paths in lines 33–36 are incorrect and will fail to resolve.

integration-tests/Cargo.toml is located at the repository root level, not in a subdirectory. The crates solana-core, core, executors, and thirdweb-core are all sibling directories at the same root level. Using relative paths with ../ will attempt to navigate outside the repository.

Correct the paths to point to the sibling directories. If this is a Rust workspace, you can either:

  • Remove the ../ prefix and reference the crates directly (if configured as workspace members)
  • Use workspace member references instead of path dependencies

Verify the workspace configuration in the root Cargo.toml and update lines 33–36 accordingly.

🤖 Prompt for AI Agents 
In integration-tests/Cargo.toml around lines 33–36 the path dependencies use
"../" which incorrectly points outside the repo; update each dependency to
reference the sibling crate directories (remove the "../" prefix so paths are
"solana-core", "core", "executors", "thirdweb-core") or, alternatively, remove
the path dependencies and add these crates as workspace members in the root
Cargo.toml; after changing, verify the root workspace configuration and run
cargo build to confirm resolution.


# Testing utilities
once_cell = "1.20"

[dev-dependencies]
thirdweb-engine = { path = "../server" }
twmq = { path = "../twmq" }
rand = { workspace = true }
Loading