Add allowLinkingProfiles to useWalletDetailsModal hook #7860

Yash094 · 2025-08-15T10:24:09Z

[SDK] Feature: Add `allowLinkingProfiles` option to `useWalletDetailsModal`

BLD-125

## Notes for the reviewer

This PR exposes the `allowLinkingProfiles` option, previously only available in `ConnectButton`, to the `useWalletDetailsModal` hook. This allows users to hide the "Linked Profiles" section within the wallet details modal.

The default behavior remains `true` (linking profiles are shown), ensuring backward compatibility.

## How to test

1.  **Verify hidden linking profiles**:
    *   Use `useWalletDetailsModal` and call `detailsModal.open()` with `manageWallet: { allowLinkingProfiles: false }`.
    *   Confirm that the "Linked Profiles" section is hidden in the wallet details modal.
2.  **Verify visible linking profiles (default/explicit true)**:
    *   Use `useWalletDetailsModal` and call `detailsModal.open()` without the `manageWallet` option, or with `manageWallet: { allowLinkingProfiles: true }`.
    *   Confirm that the "Linked Profiles" section is visible in the wallet details modal.

Slack Thread

PR-Codex overview

This PR adds functionality for managing connected wallets in the useWalletDetailsModal hook, allowing for options such as linking profiles to a wallet.

Detailed summary

Added a new optional property manageWallet to the UseWalletDetailsModalOptions type.
Introduced a sub-property allowLinkingProfiles under manageWallet, defaulting to true.
Updated the useWalletDetailsModal function to include manageWallet from props.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Co-authored-by: yashjoisar <[email protected]>

changeset-bot · 2025-08-15T10:24:13Z

⚠️ No Changeset found

Latest commit: 5dadae4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-08-15T10:24:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready	Preview	Comment	Aug 15, 2025 10:38am
nebula	✅ Ready	Preview	Comment	Aug 15, 2025 10:38am
thirdweb_playground	✅ Ready	Preview	Comment	Aug 15, 2025 10:38am
thirdweb-www	✅ Ready	Preview	Comment	Aug 15, 2025 10:38am
wallet-ui	✅ Ready	Preview	Comment	Aug 15, 2025 10:38am

coderabbitai · 2025-08-15T10:24:16Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch cursor/add-allowlinkingprofiles-to-usewalletdetailsmodal-hook-6860

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

graphite-app · 2025-08-15T10:24:17Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

cursor · 2025-08-15T10:24:17Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

github-actions · 2025-08-15T10:29:56Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	64.06 KB (0%)	1.3 s (0%)	278 ms (+128.08% 🔺)	1.6 s
thirdweb (cjs)	357.05 KB (0%)	7.2 s (0%)	917 ms (+0.43% 🔺)	8.1 s
thirdweb (minimal + tree-shaking)	5.73 KB (0%)	115 ms (0%)	79 ms (+1184.32% 🔺)	194 ms
thirdweb/chains (tree-shaking)	526 B (0%)	11 ms (0%)	66 ms (+2371.43% 🔺)	77 ms
thirdweb/react (minimal + tree-shaking)	19.15 KB (0%)	383 ms (0%)	85 ms (+448.91% 🔺)	468 ms

codecov · 2025-08-15T10:31:36Z

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.34%. Comparing base (b1ac15c) to head (5dadae4).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	0.00%	2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7860      +/-   ##
==========================================
- Coverage   56.34%   56.34%   -0.01%     
==========================================
  Files         905      905              
  Lines       58834    58836       +2     
  Branches     4150     4151       +1     
==========================================
  Hits        33151    33151              
- Misses      25577    25579       +2     
  Partials      106      106

Flag	Coverage Δ
packages	`56.34% <0.00%> (-0.01%)`	⬇️

Files with missing lines	Coverage Δ
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx	`57.82% <0.00%> (-0.11%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

MananTank · 2025-08-18T17:03:19Z

Close in favor of #7865

Add manageWallet option to wallet details modal configuration

5dadae4

Co-authored-by: yashjoisar <[email protected]>

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Aug 15, 2025

github-actions bot assigned Yash094 Aug 15, 2025

vercel bot deployed to Preview – nebula August 15, 2025 10:26 View deployment

vercel bot deployed to Preview – thirdweb_playground August 15, 2025 10:26 View deployment

vercel bot deployed to Preview – thirdweb-www August 15, 2025 10:32 View deployment

vercel bot deployed to Preview – docs-v2 August 15, 2025 10:37 View deployment

vercel bot deployed to Preview – wallet-ui August 15, 2025 10:38 View deployment

MananTank closed this Aug 18, 2025

MananTank deleted the cursor/add-allowlinkingprofiles-to-usewalletdetailsmodal-hook-6860 branch August 18, 2025 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add allowLinkingProfiles to useWalletDetailsModal hook #7860

Add allowLinkingProfiles to useWalletDetailsModal hook #7860

Uh oh!

Yash094 commented Aug 15, 2025 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Aug 15, 2025

Uh oh!

vercel bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 15, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

graphite-app bot commented Aug 15, 2025

Uh oh!

cursor bot commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

codecov bot commented Aug 15, 2025 •

edited

Loading

Uh oh!

MananTank commented Aug 18, 2025

Uh oh!

Uh oh!

Add allowLinkingProfiles to useWalletDetailsModal hook #7860

Add allowLinkingProfiles to useWalletDetailsModal hook #7860

Uh oh!

Conversation

Yash094 commented Aug 15, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Aug 15, 2025

⚠️ No Changeset found

Uh oh!

vercel bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Aug 15, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

graphite-app bot commented Aug 15, 2025

How to use the Graphite Merge Queue

Uh oh!

cursor bot commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

size-limit report 📦

Uh oh!

codecov bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MananTank commented Aug 18, 2025

Uh oh!

Uh oh!

Yash094 commented Aug 15, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Aug 15, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Aug 15, 2025 •

edited

Loading