Skip to content
This repository was archived by the owner on Aug 30, 2022. It is now read-only.

[breaking] - init v3 changes, new sdk, new wagmi, new connectors #91

Closed
wants to merge 16 commits into from

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 19, 2022

No description provided.

@jnsdls
Copy link
Member Author

jnsdls commented Jun 19, 2022

requires thirdweb-dev/typescript-sdk#477

@jnsdls
Copy link
Member Author

jnsdls commented Jun 19, 2022

will fix: #89, #46, #80

@joaquim-verges
Copy link
Member

Feedback/walkthrough experience upgrading an existing repo (ethrone):

  • chainId is still required in ThirdwebProvider
  • Module '"@thirdweb-dev/react"' has no exported member 'useAddress' - guess i have to use useAccount from wagmi? kinda wish we'd export that, it's so convenient for everything
  • had to change the default useMetamask to useQuery format const { connect: connectWithMetamask } = useMetamask();

super weird error with basic useMetamask setup + useAccount for the address:

Warning: Text content did not match. Server: "Connect with Metamask" Client: "Disconnect"

looks like server vs client tried to render something diff, not sure if its our hook or wagmi's fault

@jnsdls jnsdls marked this pull request as ready for review June 28, 2022 21:06
@jnsdls
Copy link
Member Author

jnsdls commented Jun 28, 2022

Feedback/walkthrough experience upgrading an existing repo (ethrone):

  • chainId is still required in ThirdwebProvider

fixed

  • Module '"@thirdweb-dev/react"' has no exported member 'useAddress' - guess i have to use useAccount from wagmi? kinda wish we'd export that, it's so convenient for everything

fixed

  • had to change the default useMetamask to useQuery format const { connect: connectWithMetamask } = useMetamask();

will probably stay this way

super weird error with basic useMetamask setup + useAccount for the address:

Warning: Text content did not match. Server: "Connect with Metamask" Client: "Disconnect"

looks like server vs client tried to render something diff, not sure if its our hook or wagmi's fault

working on it with tom

@jnsdls jnsdls closed this Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants