Run example tests on CI #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
ci: exclude test_compute_alignment from unit tests
Signed-off-by: Paul Zabelin <[email protected]>
…ssues Signed-off-by: Paul Zabelin <[email protected]>
carl
reviewed
Mar 27, 2025
refactor: simplify embedding creation by removing model parameter and setting default Signed-off-by: Paul Zabelin <[email protected]>
# Conflicts: # examples/team_recommender/tests/example_1_text_response/openai_embeddings.py # examples/team_recommender/tests/example_1_text_response/snapshots/test_compute_cosine_similarity/test_reproducing_the_same_text_embedding/hallucination_response_large_same_text_embedding.json # examples/team_recommender/tests/example_1_text_response/test_good_fit_for_project.py
Signed-off-by: Paul Zabelin <[email protected]>
Contributor
|
🐻 approved |
carl
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use smaller embedding size to stabilize snapshots tests.
This pull request includes several changes to the
examples/team_recommender/tests/example_1_text_responseand related files to improve the handling of embedding models, refactor functions, and update test cases. The most important changes include modifying theget_embeddingfunction to use a constant for embedding dimensions, refactoring thecreate_embedding_objectfunction, and updating test cases to reflect these changes.Improvements to embedding models:
examples/team_recommender/tests/example_1_text_response/openai_embeddings.py: Modified theget_embeddingfunction to use a constantembedding_dimensionsand refactored thecreate_embedding_objectfunction to separate model handling into a new functioncreate_embedding_object_model. [1] [2] [3]Updates to test cases:
examples/team_recommender/tests/example_1_text_response/test_compute_alignment.py: Updated thetest_compute_alignmentfunction to remove the model parameter fromcreate_embedding_objectcalls and added apytest.mark.xfaildecorator to indicate expected failures.examples/team_recommender/tests/example_1_text_response/test_compute_cosine_similarity.py: Removed thepytest.mark.xfaildecorator fromtest_reproducing_the_same_text_embeddingand updated tolerance levels intest_embedding_equivalence. [1] [2]examples/team_recommender/tests/example_1_text_response/test_good_fit_for_project.py: Updated thetest_llm_will_hallucinate_given_no_datafunction to reflect changes in embedding dimensions.Minor improvements:
examples/team_recommender/tests/example_6_n_generations/test_faster_with_n_generations.py: Added initialization ofjson_objectto avoid potential reference errors.examples/team_recommender/tests/example_7_schema_validators/test_response_has_valid_schema.py: Added initialization ofjson_objectto avoid potential reference errors.