cleanup code, improve folder names #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update unique ID format in reporter.py Signed-off-by: Paul Zabelin <[email protected]>
remove extra packages in test, rename test files for clarity Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
Signed-off-by: Paul Zabelin <[email protected]>
This reverts commit 041fb73.
for github action: Error: The path for one of the files in artifact is not valid: /test_allocations_hallucinating-0305-20:12:08/0-True.json. Contains the following character: Colon : Invalid characters include: Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n The following characters are not allowed in files that are uploaded due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems. Signed-off-by: Paul Zabelin <[email protected]>
tkersey
approved these changes
Mar 5, 2025
Contributor
There was a problem hiding this comment.
PR Overview
This PR focuses on cleaning up the code and improving folder naming conventions. The changes include:
- Updating the timestamp format in the Reporter class for creating unique IDs.
- Renaming a test function for increased clarity.
- Removing an unused import in an example test file.
Reviewed Changes
| File | Description |
|---|---|
| src/cat_ai/reporter.py | Updated the timestamp format used in unique ID generation, which affects folder naming. |
| tests/test_reporter.py | Renamed the test function to better reflect its purpose. |
| examples/team_recommender/tests/example_4_loop_no_hallucinating/test_allocations_hallucinating.py | Removed an unused import to clean up the code. |
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comment on lines
+14
to
15
| return datetime.now().strftime("%m%d-%H_%M_%S") | ||
|
|
There was a problem hiding this comment.
The new timestamp format omits the year, which may reduce uniqueness over different years if the output directory is reused. Consider including the year (e.g., "%Y%m%d-%H_%M_%S") to ensure folder names remain distinct.
Suggested change
| return datetime.now().strftime("%m%d-%H_%M_%S") | |
| return datetime.now().strftime("%Y%m%d-%H_%M_%S") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.