Skip to content

Conversation

@rabail-aamir
Copy link

Description

This PR adds documentation for the CSharpWasm implementation in SK Online.
The document (CSharpWasm.md) explains the project’s purpose, layout, prerequisites, build & copy process, browser usage, and troubleshooting.

This helps contributors understand how to run and extend the C# WebAssembly integration.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • [✓ ] Documentation (update or new)

How Has This Been Tested?

The document was reviewed locally for accuracy and formatting.
No code changes are included in this PR.

Testing Checklist

[✓ ] Verified Markdown renders correctly in GitHub preview.
[✓ ] Checked links, commands, and code snippets for correctness.

Checklist

  • [✓ ] My code follows the style guidelines of this project
  • [✓ ] I have performed a self-review of my own code
  • [ ✓] I have commented my code in hard-to-understand areas
  • [✓ ] I have made corresponding changes to the documentation
  • [✓ ] My changes generate no new warnings
  • [ ✓] I have requested a review from ... on the Pull Request

Copy link
Collaborator

@Oliver-Quail Oliver-Quail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rabail-aamir,
Firstly this PR is a really good base. I think a few minor changes are needed though and it will be ready

- Your project folder CSharpWasmExpo requires either a local development environment or a hosting solution to function.

## Build and Copy Process
You can create and distribute the artifacts through the following command which needs to be executed from the `CSharpWasm/` directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a note here that tells Windows users to use this script with WSL or MINGW to run the script

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thx

Comment on lines 65 to 74
const code =
using System;
class Program {
static void Main() {
Console.WriteLine("Hello from C#!");
}
};

const result = await globalThis.CSharpCodeRunner.CompileAndRun(code);
console.log(result);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this code would actually work with the current implementation.

You should just be able to execute raw C# code and it should work, no Javascript required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants