-
Notifications
You must be signed in to change notification settings - Fork 28
docs: add overview documentation for CSharpWasm #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Oliver-Quail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rabail-aamir,
Firstly this PR is a really good base. I think a few minor changes are needed though and it will be ready
| - Your project folder CSharpWasmExpo requires either a local development environment or a hosting solution to function. | ||
|
|
||
| ## Build and Copy Process | ||
| You can create and distribute the artifacts through the following command which needs to be executed from the `CSharpWasm/` directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a note here that tells Windows users to use this script with WSL or MINGW to run the script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thx
Documentation/CSharpWasm.md
Outdated
| const code = | ||
| using System; | ||
| class Program { | ||
| static void Main() { | ||
| Console.WriteLine("Hello from C#!"); | ||
| } | ||
| }; | ||
|
|
||
| const result = await globalThis.CSharpCodeRunner.CompileAndRun(code); | ||
| console.log(result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this code would actually work with the current implementation.
You should just be able to execute raw C# code and it should work, no Javascript required
…d corrected usage example
Description
This PR adds documentation for the CSharpWasm implementation in SK Online.
The document (CSharpWasm.md) explains the project’s purpose, layout, prerequisites, build & copy process, browser usage, and troubleshooting.
This helps contributors understand how to run and extend the C# WebAssembly integration.
Type of change
expected)
How Has This Been Tested?
The document was reviewed locally for accuracy and formatting.
No code changes are included in this PR.
Testing Checklist
[✓ ] Verified Markdown renders correctly in GitHub preview.
[✓ ] Checked links, commands, and code snippets for correctness.
Checklist