-
Notifications
You must be signed in to change notification settings - Fork 69
Update unit testing guide #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dijidiji
wants to merge
19
commits into
thoth-tech:main
Choose a base branch
from
dijidiji:update-unit-test-guide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where resources for tests (such as images) aren't copied, causing tests to fail. This happens because building a specific executable target such as skunit_tests doesn't run the custom targets used for the copy. This could be fixed by altering CMakeLists.txt but updating this guide is simpler.
✅ Deploy Preview for thoth-tech ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for strong-fairy-c1bde1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've revised and updated the unit testing guide. I've also merged previous testing instructions for
sktestwith relevant instructions that were part of the unit testing guide, since the build process builds both. As part of this, I've elaborated on the differences betweensktestandskunit_testsa bit, and moved the part of the guide that outlined how to write a unit test to a separate page.This way, someone following the guide is made aware of how to run both test programs, and is informed of how to add tests to either of them (as well as the reasons for doing so).
Type of change
How Has This Been Tested?
Made sure the guide looks good in local testing.
Testing Checklist
npm run formatnpm run buildnpm run devand/ornpm run preview, using:Checklist