-
Notifications
You must be signed in to change notification settings - Fork 27
Update grant extension feature docs for frontend and API #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update grant extension feature docs for frontend and API #40
Conversation
❌ Deploy Preview for ontrackdocumentation failed.
|
|
Hi @samindiii , I'll be completing a junior peer review for your documentation changes. To review this, I've accessed the preview of the documentation via Netlify. Frontend Documentation Review
Overall, well done. I approve of these changes. The only suggestion I have is to include the type of data returned from the backend, so that it's clear how to handle the response from the server. Backend Documentation Review
Well done. The only suggestion I have is to amend the grammar, looking for places that need full stops, etc. I approve these changes. |
returnMarcco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a review in the conversation section of the PR.
|
Hi @samindiii, I've reviewed the documentation, I accessed the preview via Netlify. Frontend Documentation
Overall, the front end documentation looks good to me! Backend Documentation
Overall, the backend documentation looks good to me! Well done :) I approve these changes. |
32b11aa to
74d47f3
Compare
74d47f3 to
6fa5084
Compare
|
I'll update this PR again at the end of the trimester once the staff grant extension feature is complete. |
Description
This update includes:
Additionally, added a front-end component list page to match the backend API page.
Fixes # (issue)
Type of change
How Has This Been Tested?
I tested this by
npm installnpm run devAlternatively, visit the deploy preview link (https://deploy-preview-40--ontrackdocumentation.netlify.app/) and navigate to documentation/front_end/staff_grant extension and documentation/backend/api/staff_grant_extension.
Testing Checklist
Checklist