-
Notifications
You must be signed in to change notification settings - Fork 27
Cryptography Audit #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
-README file for the Cryptography Audit test
❌ Deploy Preview for ontrackdocumentation failed.
|
martindolores
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work so far! Looks good to me but there is some failing checks
| # Cryptographic Security Audit Script | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs a title like so
| # Cryptographic Security Audit Script | |
| --- | |
| title: Cryptographic Security Audit Script | |
| --- |
martindolores
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in meeting, to keep it consistent with other audits, this is fine. Great work :)
samindiii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deploy preview doesn't seem to work- maybe because of the failing checks. Had a look over the audit and it is structured well and written well! Great work :)
ibi420
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Iris, I’ve gone through your report and it looks good. In addition to Martin’s feedback, I recommend updating the report name from Readme to crypto_audit_documentation.md. The script runs smoothly and generates the report on my end. Other than that, everything looks fine. Thank you for giving me the opportunity to review your work.
Hi @ibi420 thanks for the suggestions and please check it’s renamed. |
Description
This script performs a cryptographic security audit. It is compatible with macOS and Linux, and evaluates three key areas:
The results are saved to a log file and also shown in the terminal with clear pass/warn/fail indicators.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
expected)
Testing Checklist
Checklist