-
Notifications
You must be signed in to change notification settings - Fork 27
Publicly Accessible API Documentation via Swagger vulnerability remediation doc #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…iation documentation
❌ Deploy Preview for ontrackdocumentation failed.
|
martindolores
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation looks good to me! Not sure if this one is ready as you have put it in draft?
martindolores
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work :)
| The following components and files were updated as part of this security enhancement: | ||
| - **doubtfire-api:** | ||
| - Updated the Swagger initializer to disable Swagger in production. | ||
| - **Affected file:** `config/initializers/swagger.rb` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add the changed or the newly added code segment to signify the difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not good practice to reveal security code in documentation, as it gives attackers knowledge on how to circumvent them.
|
Hi @ibi420, I have reviewed the documentation, and everything looks good. No further comments from my side. |
Description
This change addresses a vulnerability where Swagger API documentation was publicly accessible in production environments. Swagger has now been disabled in production to prevent unauthorised users from discovering sensitive backend routes and internal API details.
Fixes # (issue)
Type of change
How Has This Been Tested?
/api/swagger_doc.json,/swagger_doc.json) in a production environment./home) and Swagger documentation is no longer exposed.Testing Checklist
Checklist