Fix/clickjacking vulnerability #319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new Numbas Service to the frontend as part of Integration Changed by: Daniel Maddern
adjusted lint on edit-profile-component.spec.ts Changed by: Daniel Maddern
Added numbas service and numbas service test daniel
added a spec test file for numbas service daniel
added the lms service code and functionality Added by Daniel
added the spec test basic version for numbas-lms service Added by Daniel
removed the addtional comma added into this component daniel
renamed api endpoint to reduce confusion between components
- checks with weighted grading - provides a link to open D2L unit edit for weight
New/d2lintegration - Introduce D2L integration for grade transfer
Where the staff member is the student. Also ensures the current user is in the cache when they login from cookie.
This should ensure that the new html5 urls work correctly.
- Add directory to direct to index.html - Add root index.html otherwise
Fixes issues with task definitions not getting their id when created. Which caused upload of task sheets to fail until reloaded.
Make sure roll over in a unit indicates it copies to a new teaching period or custom dates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base Repository: 8.0.x
Description
This PR ensures that the internal
nginx.confinsidedoubtfire-webdoes not override the security headers (e.g.,X-Frame-Options,Content-Security-Policy) that are now being enforced via the outerproxy-nginx.conffile in thedoubtfire-deployrepository.Note
Kindly go through the attached documentation first inorder to understand what this fix is about in detail and how it can be tested.
What was changed:
doubtfire-web/nginx.confto prevent conflict or override with headers applied at the reverse proxy layer (proxy-nginx.conf).Fixes # (Header override issues caused by multiple NGINX layers)
Type of change
How Has This Been Tested?
proxy-nginx.conf(doubtfire-deploy) reflect in browser responsedoubtfire-web/nginx.confTesting Checklist:
Checklist: