Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport from parent repo - Allow upgrade of HTTParty and Nokogiri #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Backport from parent repo - Allow upgrade of HTTParty and Nokogiri #3

wants to merge 1 commit into from

Conversation

florrain
Copy link
Member

@florrain florrain commented Sep 13, 2018 •
edited
Loading

Cherry-Pick of jazminschroeder#129

Needed to bump Ruby and silence warnings:

/Users/flo/.rvm/gems/ruby-2.3.7@tu3/gems/json-1.8.6/lib/json/common.rb:155: warning: HTTParty::Response#respond_to?(:to_str) is old fashion which takes only one parameter
/Users/flo/.rvm/gems/ruby-2.3.7@tu3/gems/httparty-0.12.0/lib/httparty/response.rb:53: warning: respond_to? is defined here

This will be tested on staging before being merged.

@mahasamatman mahasamatman self-requested a review September 13, 2018 17:18
mahasamatman
mahasamatman approved these changes Sep 14, 2018
View reviewed changes
Copy link

@mahasamatman mahasamatman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this locally using remote branch. please don't forget to bump gem version before merge.
🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahasamatman mahasamatman mahasamatman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florrain @mahasamatman @alexQueue